fix: fedora build compatibility #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora and other distributions with strict PIE requirements need position-independent code when linking static libraries into Rust binaries. This adds -fPIC to the C compilation in build.rs and enables CMAKE_POSITION_INDEPENDENT_CODE for the picoquic build.
There was a problem hiding this comment.
Pull request overview
This pull request fixes build compatibility for Fedora and other Linux distributions with strict Position Independent Executable (PIE) requirements by adding position-independent code flags to C compilation steps.
Changes:
- Added
CMAKE_POSITION_INDEPENDENT_CODE=ONflag to picoquic CMake build configuration - Added
-fPICflag to C compiler invocations in the Rust FFI build script
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/build_picoquic.sh | Enables position-independent code generation for the picoquic CMake build |
| crates/slipstream-ffi/build.rs | Adds -fPIC flag to both C compilation helper functions used when building FFI objects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora and other distributions with strict PIE requirements need position-independent code when linking static libraries into Rust binaries. This adds
-fPICto the C compilation inbuild.rsand enablesCMAKE_POSITION_INDEPENDENT_CODEfor the picoquic build.