Add Tasker Actions for managing Downstreams

[XamarinDeveloper]

Needed it so implemented it.

[Mygod]

No Tasker functionality will be merged without proper permission checks. This app handles dangerous system networking stack and should not be exposed.

[XamarinDeveloper]

Doesn't the action I've added require root privileges?
I honestly don't know if there is another way to do it. I have root, and in the emulator it didn't work w/o root, so I assumed it needs root
But if it does need root privileges, then a permission check is unnecessary?

Edit: Also, if the permission check is necessary, how can I have a permission check parallel to a root check so if any one of them exists, it'll work? (Right now, my app denies permission check for the Tasker tether actions, although I have granted root)

[Mygod]

The action uses root, which is different from requiring the caller (presumably Tasker but could also be a malicious app) to have appropriate permissions.

VPN Hotspot app caches and reuses root sessions, which also makes it hard to see when root is used but that's besides the point.

[XamarinDeveloper]

Ah ok, alright, which permissions should I check for? this one doesn't have to do directly with tethering, is secure settings alone good?

And would adding a checkbox to the settings where one could allow bypassing the permission checks (with a pop-up warning upon trying to enable it) be an acceptable compromise? (I mean with these kinds of apps that are made for power users I believe in the end the choice should be theirs)
I ask this because I myself can't use the features since I haven't made the apps a system app and can't give those permissions to it.