Assembly helper functions #25
Conversation
|
@codex review this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sbs_server/app/utils.py
Outdated
|
|
||
| return part_documents, backbone_doc, abstract_design_id | ||
|
|
||
| def sbol2build_moclo(part_documents: List[sbol2.Document], backbone_doc: sbol2.document, abstract_design_id: str) -> sbol2.Document: |
There was a problem hiding this comment.
The new helper declares backbone_doc: sbol2.document, but sbol2 exposes Document with a capital D and has no attribute document. Because annotations are evaluated at definition time, importing this module will immediately raise AttributeError: module 'sbol2' has no attribute 'document', so none of the utilities can be used. Use sbol2.Document (or a string annotation) to avoid the runtime failure.
Useful? React with 👍 / 👎.
sbs_server/app/views.py
Outdated
| print(abstract_design_uri, plasmid_collection_uri, plasmid_vector_uri, auth_token) | ||
|
|
||
| return 0 |
There was a problem hiding this comment.
The new /abstract_design_2_plasmids route finishes with return 0, which Flask treats as an invalid response type and raises TypeError: The view function did not return a valid response whenever the endpoint is hit. This makes the endpoint unusable even when all inputs are present. Return a JSON response or a proper tuple/status code instead of a bare integer.
Useful? React with 👍 / 👎.
|
codex comments addressed in most recent commit. upload_assembly endpoint works up until submission of assembly plan to sbh collection, tested with: postman api call |
abstract_design_2_plasmids:sbol2build_moclo: