Skip to content

Conversation

@Gonza10V
Copy link
Contributor

Motivation

  • Allow callers to control where the assembly-plan JSON is written so downstream steps (zip/simulation) can rely on a known file location instead of a hardcoded output.json.

Description

  • Add an optional output_path: str | Path | None parameter to assembly_plan_RDF_to_JSON and write JSON to the provided path, defaulting to output.json when omitted (src/buildcompiler/robotutils.py).
  • Update assembly_compiler to call assembly_plan_RDF_to_JSON(..., output_path=f"{files_path}/assemblyplan_output.json") so the zip step uses the generated file (src/buildcompiler/buildcompiler.py).
  • Normalize SBOL type checks to use isinstance(file, sbol2.Document) in both robotutils modules and tidy up a now-unused import/assignment in the build compiler.

Testing

  • Ran pytest, which executed the test suite but produced network-related failures/errors against external services (proxy blocked access to synbiohub.org / validator.sbolstandard.org), so several tests failed or errored; this is due to external network validation calls, not the JSON output change.
  • Ran ruff check src, which passed with no remaining lint errors.

Codex Task

@Gonza10V Gonza10V merged commit 5eee841 into main Jan 16, 2026
4 checks passed
@Gonza10V Gonza10V deleted the codex/update-assembly_plan_rdf_to_json-output-path branch January 16, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants