🚀 Better console color system by ItsTheSky · Pull Request #134 · Mwexim/skript-parser

ItsTheSky · 2022-06-28T17:00:59Z

These small changes allow better customization & organization of console colors.

Example code:

on script load:
    print "<orange>This is in orange, <yellow>and this in yellow.<reset>"
    print "<cyan><b>This is bold cyan,<reset> and this is not bold neither colored!"
    print "<pink><u>This is underlined pink,<reset><color=purple_background> I'M BATMAN!"

Output:

Main Changes:

Each color has its own code only. The escaping symbol and delimiter are added after.
Each color can now have aliases, for example, orange_bright could also be used as yellow.
Color, style and background can now be superposed (wasn't possible before, it was clearing the color when applying a style)

Olyno

Hi 👋🏻 Thanks you for your contributions. Here is a list of some changes i would like to see in a first review.

Olyno · 2022-06-28T19:28:04Z

src/main/java/io/github/syst3ms/skriptparser/expressions/ExprAsk.java

@@ -0,0 +1,53 @@
+package io.github.syst3ms.skriptparser.expressions;


Not related to this pull request

Was made basing myself on my other PR.
Not sure how should I do now.

You can delete the files locally and push the changes here. It will remove the files from the PR as Github compares with the latest commit in the master branch.

src/main/java/io/github/syst3ms/skriptparser/tags/TagColor.java

Olyno · 2022-06-28T19:29:25Z

src/main/java/io/github/syst3ms/skriptparser/util/color/ConsoleColors.java

+    ITALIC("3", true, "o"),
+    UNDERLINE("4", true, "n", "u"),
+    STRICKTHROUGH("9", true, "m", "strike"),
+    ;


Something wrong here

What's wrong here?

Looks line 46

I still don't see what's wrong, is it the constant's name ?
It has been renamed by Mwexim

src/main/java/io/github/syst3ms/skriptparser/util/color/ConsoleColors.java

Mwexim

Great additions!

Mwexim · 2022-07-08T11:10:08Z

src/main/java/io/github/syst3ms/skriptparser/tags/TagColor.java

+    @Override
+    public boolean init(String key, String[] parameters) {
+        final Optional<ConsoleColors> optional;
+        if (key.equalsIgnoreCase("color") && parameters.length != 0) {


Probably should check for length 1.

Mwexim · 2022-07-08T11:20:22Z

src/main/java/io/github/syst3ms/skriptparser/tags/TagReset.java


 	public String getValue(String affected) {
-		return affected;
+		return ConsoleColors.RESET + affected;


While this implementation is correct for now, it reminds me that a small overhaul of the tag system is needed in order to give addons the flexibility of changing the reset tag.

src/main/java/io/github/syst3ms/skriptparser/util/color/ConsoleColors.java

src/main/java/io/github/syst3ms/skriptparser/tags/TagColor.java

WeeskyBDW · 2022-08-03T16:18:32Z

src/main/java/io/github/syst3ms/skriptparser/Parser.java

            ConsoleColors color = ConsoleColors.WHITE;
            if (log.getType() == LogType.WARNING) {
-                color = ConsoleColors.YELLOW;
+                color = ConsoleColors.ORANGE;


i dont think change to orange is a good idea since yellow is in general associate with warning so it would imo create bad idea of warning for skript users that would next switch to another language

…eColors.java Co-authored-by: Mwexim <38397639+Mwexim@users.noreply.github.com>

Co-authored-by: Mwexim <38397639+Mwexim@users.noreply.github.com>

…eColors.java Co-authored-by: Mwexim <38397639+Mwexim@users.noreply.github.com>

WeeskyBDW · 2024-02-12T07:52:46Z

👋 @ItsTheSky
This PR is open since a while and i see no more activity about it, is it ready for reviewing ? do you need help ? this comment isn't and shouldn't be take as blaming at all

ItsTheSky · 2024-03-09T12:23:11Z

Hi! Sorry for taking so long to reply too 😭
I don't currently plan to work on this PR anymore as it seems this repo is archived.
However if it's still updated and have a future I'll be glad to go hop in again :D

Mwexim · 2024-03-27T10:48:09Z

I think the tag system needs a major overhaul, which is one of the reasons this pull request stays open currently. The code itself is good and if there would be any changes I'd want to make, I'd probably make a quick commit myself.

If I ever get more time to work on this project, this should be handled rather quickly.

ItsTheSky added 6 commits March 27, 2022 14:59

✨ Added 'ask' section & 'last answer' expression

893d389

⚡ Moved toString method to the end of the class

ace7e37

⚡ Changed ask section into effect

735d12a

⚡ Some requested changes

ef9bab2

⚡ Optimized & reworked the ask effect/expression

03bd6d6

🚀 Implemented better console color system

113302f

Olyno suggested changes Jun 28, 2022

View reviewed changes

⚡ Fixed wrong brackets definition

27ca17f

ItsTheSky requested a review from Olyno June 28, 2022 20:04

Mwexim requested changes Jul 8, 2022

View reviewed changes

WeeskyBDW reviewed Aug 3, 2022

View reviewed changes

ItsTheSky and others added 3 commits August 3, 2022 20:22

Update src/main/java/io/github/syst3ms/skriptparser/util/color/Consol…

cc263cc

…eColors.java Co-authored-by: Mwexim <38397639+Mwexim@users.noreply.github.com>

Update src/main/java/io/github/syst3ms/skriptparser/tags/TagColor.java

578bc75

Co-authored-by: Mwexim <38397639+Mwexim@users.noreply.github.com>

Update src/main/java/io/github/syst3ms/skriptparser/util/color/Consol…

dad941d

…eColors.java Co-authored-by: Mwexim <38397639+Mwexim@users.noreply.github.com>

		@@ -0,0 +1,53 @@
		package io.github.syst3ms.skriptparser.expressions;

Conversation

ItsTheSky commented Jun 28, 2022

Example code:

Output:

Main Changes:

Uh oh!

Olyno left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mwexim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WeeskyBDW commented Feb 12, 2024

Uh oh!

ItsTheSky commented Mar 9, 2024

Uh oh!

Mwexim commented Mar 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants