-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add error handling and success status for screen operations #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @SurajPatil1404, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness and usability of the screen operations by introducing comprehensive error handling and explicit success status reporting. Developers can now reliably determine the outcome of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve error handling by returning a boolean success status. While this is a good goal, the current implementation in lib/src/screen_off.dart swallows exceptions, which hides important error details from developers and makes the library harder to debug. The documentation has also become inconsistent with the implementation. I've provided suggestions to let exceptions propagate, which is a more robust approach for library design. Additionally, I've found a small issue in the README.md example code where a variable is redeclared, which would cause a compile error.
|
Thank you for the detailed review and helpful suggestions! 🙏 I’ve made the following updates based on your feedback: Removed the try-catch blocks from both turnScreenOff() and turnScreenOn() to let exceptions propagate naturally, ensuring better error visibility for developers. Updated the documentation comments to clearly state that a PlatformException will be thrown on failure. Fixed the duplicate variable declaration in the README example — it now reassigns the existing success variable instead of redeclaring it. Ensured the README examples and comments are consistent with the implementation. |
I've made a meaningful contribution that improves the plugin by:
Adding error handling to screen operations
Returning boolean status to indicate operation success
Updating documentation with error handling examples
Updating the changelog
The changes:
Improve reliability by properly handling errors
Make it easier for developers to handle failures
Follow best practices for error handling
Add better documentation and examples