Merged
Conversation
Co-authored-by: sebastian_kraetzig <sebastian.kraetzig@4g-server.eu>
* Update deprecated CodeQL version CodeQL v1 will be unsupported by January 2023, so their recommendation is to update to v2, which requires no changes. * Remove deprecated `git checkout HEAD^2` step CodeQL recommends to remove this step to ensure, that the check runs against the respective latest commit. * Update checkout action version Node.js 12 actions are deprecated. Github recommends to upgrade to Node.js 16. Co-authored-by: sebastian_kraetzig <sebastian.kraetzig@4g-server.eu>
Owner
|
Sorry, I am a bit busy at the moment, this will take a bit to review (as well as the changes proposed by #23 ). |
Murgeye
reviewed
Dec 29, 2022
test_TS3Connection.py
Outdated
| resp = b"notifyclientleftview cfid=1 ctid=0 reasonid=8 " \ | ||
| b"reasonmsg=Left. clid=1" | ||
| resp = ( | ||
| b"notifyclientleftview cfid=1 ctid=0 reasonid=8 " b"reasonmsg=Left. clid=1" |
Owner
There was a problem hiding this comment.
This does not seem right, this should be changed into a single byte string.
Contributor
Author
There was a problem hiding this comment.
The behaviour shouldn't change due to this change.
Both versions should result in the same behaviour as you can see below:
>>> resp = b"notifyclientleftview cfid=1 ctid=0 reasonid=8 " \
... b"reasonmsg=Left. clid=1"
>>>
>>> print( resp )
b'notifyclientleftview cfid=1 ctid=0 reasonid=8 reasonmsg=Left. clid=1'
>>>
>>> resp = (
... b"notifyclientleftview cfid=1 ctid=0 reasonid=8 " b"reasonmsg=Left. clid=1"
... )
>>>
>>> print( resp )
b'notifyclientleftview cfid=1 ctid=0 reasonid=8 reasonmsg=Left. clid=1'
>>>
Alternativley, we can also write it like this:
>>> resp = b"notifyclientleftview cfid=1 ctid=0 reasonid=8 reasonmsg=Left. clid=1"
>>>
>>> print( resp )
b'notifyclientleftview cfid=1 ctid=0 reasonid=8 reasonmsg=Left. clid=1'
>>>
…speak3-python-api into Sebi94nbg-Implement-Black-formatter
Murgeye
approved these changes
Jan 12, 2023
Owner
Murgeye
left a comment
Murgeye
left a comment
There was a problem hiding this comment.
I have updated the pull request with some fixes regarding my newest commits. Should be good now!
Contributor
Author
|
Nice, thank you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request would introduce Black as code-style formatter.
Feel free to close it, if you're not interested. I just thought, that this would somehow improve the code-style and standardize it a bit more. :)