Upgrade to .NET 10.0 and MudBlazor V9#53
Conversation
Updated target frameworks to .NET 10.0 across multiple projects to leverage the latest runtime features. Refactored `CardClassname` in `MudXOutline.razor.cs` to use `ToDescription()` for CSS class generation. Added `net10.0` to `TargetFrameworks` in `MudX.csproj`.
Summary of ChangesHello @versile2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on advancing the project's core dependencies by upgrading several components to target .NET 10.0, ensuring the application can leverage the latest runtime features and improvements. Concurrently, it includes a refactoring within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request upgrades the project to .NET 10.0 and MudBlazor V9. While the overall transition is clear, there are several hardcoded paths in the project files that still reference .NET 9.0, which will break build cleanup targets. Additionally, there is a documentation regression where several public properties in the Lottie player components have lost their XML documentation, resulting in null descriptions in the generated API metadata. Finally, the refactoring to use a custom ToDescription extension for MudBlazor colors may lead to incorrect CSS class names.
I am having trouble creating individual review comments. Click here to see my feedback.
src/MudX.Docs.Server/MudX.Docs.Server.csproj (4)
The project has been upgraded to net10.0, but the CleanLockedFiles target (line 14) still contains a hardcoded path to net9.0. This will prevent the target from correctly cleaning up artifacts for the new target framework. Consider using $(TargetFramework) to make this path dynamic.
src/MudX.Docs/MudX.Docs.csproj (4)
Similar to the server project, the CleanLockedFiles target (line 22) still references net9.0. This should be updated to net10.0 or changed to use the $(TargetFramework) property for better maintainability.
src/MudX.Docs/wwwroot/api/Blazor.Lottie.Player.xml (225-229)
The documentation for TotalAnimationFrames has been removed. This causes the API generator to produce a null description in the corresponding JSON metadata. If this property is still part of the public API, its documentation should be preserved.
src/MudX.Docs/wwwroot/api/Blazor.Lottie.Player.xml (335-344)
The documentation for CurrentFrame and TotalFrames has been removed from the XML file. This results in a regression in the API documentation where these properties now lack descriptions in the JSON output.
src/MudX/Components/MudXOutline/MudXOutline.razor.cs (80)
The refactoring from ToDescriptionString() to ToDescription() for the Color parameter is a regression in behavior. ToDescriptionString() is a MudBlazor extension that ensures lowercase output and handles specific enum values correctly, whereas the custom ToDescription() extension returns the enum name (e.g., 'Default') if no DescriptionAttribute is present. This results in incorrect CSS class names like 'mud-theme-Default' instead of 'mud-theme-default'.
.AddClass($"mud-theme-{Color.ToDescriptionString()}")There was a problem hiding this comment.
Pull request overview
This PR aims to upgrade the MudX project to .NET 10.0 and MudBlazor V9. However, the implementation is incomplete with several critical issues.
Changes:
- Added
net10.0target framework to multiple projects (.csproj files) - Refactored one usage of
ToDescriptionString()toToDescription()in MudXOutline.razor.cs - Modified API documentation files (descriptions set to null and auto-generated IDs changed)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/MudX/MudX.csproj | Added net10.0 to TargetFrameworks (but MudBlazor version not upgraded) |
| src/MudX/Components/MudXOutline/MudXOutline.razor.cs | Changed ToDescriptionString() to ToDescription() for Color enum |
| src/MudX.Docs/wwwroot/api/LottiePlayerModule.api.json | Property descriptions set to null |
| src/MudX.Docs/wwwroot/api/LottiePlayer.api.json | Property description set to null, auto-generated ElementId changed |
| src/MudX.Docs/wwwroot/api/Blazor.Lottie.Player.xml | XML documentation entries removed |
| src/MudX.Docs/MudX.Docs.csproj | Updated TargetFramework to net10.0 |
| src/MudX.Docs.Server/MudX.Docs.Server.csproj | Updated TargetFramework to net10.0 |
| src/MudX.Docs.Hybrid/MudX.Docs.Hybrid/MudX.Docs.Hybrid.csproj | Updated TargetFramework to net10.0 |
| src/MudX.Docs.Hybrid/MudX.Docs.Hybrid.Client/MudX.Docs.Hybrid.Client.csproj | Updated TargetFramework to net10.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated target frameworks to .NET 10.0 across multiple projects to leverage the latest runtime features. Refactored
CardClassnameinMudXOutline.razor.csto useToDescription()for CSS class generation. Addednet10.0toTargetFrameworksinMudX.csproj.Closes #52
✨ What’s New or Changed?
📸 Screenshots / Demos (if applicable)
🧪 How Was It Tested?
📂 Type of Change
✅ Ready for Review
dev)