Skip to content

Adapt to https://github.com/rocq-prover/rocq/pull/21611#426

Merged
Janno merged 1 commit intoMtac2:masterfrom
proux01:rocq21611
Feb 26, 2026
Merged

Adapt to https://github.com/rocq-prover/rocq/pull/21611#426
Janno merged 1 commit intoMtac2:masterfrom
proux01:rocq21611

Conversation

@proux01
Copy link
Contributor

@proux01 proux01 commented Feb 18, 2026

Adapt to rocq-prover/rocq#21611

This is backward compatible.

@Janno
Copy link
Collaborator

Janno commented Feb 18, 2026

This is a bit odd. m:{ x & .. } was defined to be similar to { x & .. }. Are both notations going to be illegal in the future? I don't see changes to Specif.v in the rocq PR.

@proux01
Copy link
Contributor Author

proux01 commented Feb 18, 2026

{ x & z } is fine, the issue comes with x .. y & _ with x, y binder since now & _ will be parsed as another binder so the notation simply becomes impossible to parse, like if you were to define some x .. y ( z : w ). notation with x, y binder, any concrete ( _ : _ ) would be parsed a a binder in the x .. y sequence.

@Janno
Copy link
Collaborator

Janno commented Feb 18, 2026

I see. I missed the difference in recursiveness. I will try to push a change that makes these notations non-recursive. They should actually be used somewhere so changing to | instead of & is not the ideal solutions.

@proux01
Copy link
Contributor Author

proux01 commented Feb 18, 2026

If you want to keep the recursivity, maybe something like x , .. , y & z would work (at least that wouldn't require changing the use with a single binder)

@proux01
Copy link
Contributor Author

proux01 commented Feb 19, 2026

Indeed, here is a solution that keeps the uses with a single binder (without change) while still allowing some kind of recursive version

@proux01
Copy link
Contributor Author

proux01 commented Feb 26, 2026

@Janno would the current solution work?

@Janno
Copy link
Collaborator

Janno commented Feb 26, 2026

Sorry, I lost track of this. I just tested your changes and I they work for me. Thanks!

@Janno Janno merged commit e66a17d into Mtac2:master Feb 26, 2026
1 of 2 checks passed
@proux01
Copy link
Contributor Author

proux01 commented Feb 26, 2026

Thanks

@proux01 proux01 deleted the rocq21611 branch February 26, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants