Skip to content

Remove Poetry files and complete uv migration#4

Merged
MrLYC merged 12 commits intomainfrom
devin/1770481134-cleanup-poetry-files
Feb 7, 2026
Merged

Remove Poetry files and complete uv migration#4
MrLYC merged 12 commits intomainfrom
devin/1770481134-cleanup-poetry-files

Conversation

@MrLYC
Copy link
Owner

@MrLYC MrLYC commented Feb 7, 2026

Remove Poetry files and complete uv migration

Summary

Cleans up all remaining Poetry-related files and configuration after the uv migration in PR #3. The project now uses uv exclusively as its package manager.

Deleted files:

  • poetry.lock, poetry.toml — replaced by uv.lock (already committed)
  • .github/actions/setup-poetry-env/action.yml — unused composite action
  • requirements_ci.txt — only contained ycyc, used by old make check integration tests
  • tox.ini — referenced Poetry and outdated Python versions (3.8–3.11)

Modified files:

  • pyproject.toml — removed [tool.poetry], [tool.poetry.dependencies], [tool.poetry.dev-dependencies] sections
  • .github/workflows/main.yml — removed Poetry installation steps, CI now runs make test only
  • Makefilecheck target now runs pre-commit run -a instead of versifier integration commands; publish target uses uv publish instead of poetry publish

Review & Testing Checklist for Human

  • make check no longer runs versifier integration tests — the old check target ran versifier requirements-to-poetry, extract-private-packages, and poetry-to-requirements as integration tests against this repo. These are now replaced with pre-commit run -a. Verify you're okay losing this integration coverage (unit tests still cover 117 tests at 98% coverage)
  • CI only runs make test, not make check — pre-commit hooks are no longer exercised in CI. Consider whether make test check should be restored in CI
  • publish target lost dry-run step — previously did poetry publish --dry-run before actual publish. Now directly runs uv publish. Confirm this is acceptable for your release workflow
  • [tool.poetry] removalversifier/poetry.py reads poetry.lock and calls Poetry CLI internally. Running versifier's own CLI commands (e.g. versifier extract-private-packages) on this repo itself will no longer work since poetry.lock and [tool.poetry] are gone. This only affects using versifier on its own repo, not on other target repos

Notes

  • The [tool.versifier] config section is preserved (still references private_packages, poetry_extras, etc.)
  • uv.lock was already committed in the previous PR and is unaffected by this change

Link to Devin run: https://app.devin.ai/sessions/2b89e39464164fe085c3208ff2b164d7
Requested by: @MrLYC

Co-Authored-By: 刘奕聪 <github@m.mrlyc.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finishes the repository’s migration from Poetry to uv by removing remaining Poetry-related files/config and simplifying local/CI workflows to rely on uv.

Changes:

  • Deleted Poetry and tox artifacts (poetry.lock, poetry.toml, tox.ini) plus now-unused CI requirements/action files.
  • Removed [tool.poetry*] sections from pyproject.toml, leaving the project on PEP 621 metadata + uv lockfile usage.
  • Updated Makefile and GitHub Actions workflow to stop installing/using Poetry and to run tests via uv.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tox.ini Removed tox configuration tied to Poetry and older Python versions.
requirements_ci.txt Removed legacy CI requirements file (ycyc only).
pyproject.toml Dropped Poetry configuration sections after uv migration.
poetry.toml Removed Poetry virtualenv configuration.
poetry.lock Removed Poetry lockfile (uv lockfile is used instead).
Makefile Replaced integration-style check with pre-commit; switched publish from Poetry to uv publish.
.github/workflows/main.yml Removed Poetry installation and stopped running make check in CI (tests only).
.github/actions/setup-poetry-env/action.yml Deleted unused composite action for Poetry environment setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Makefile Outdated
Comment on lines +9 to +10
@echo "🚀 Running code quality checks"
@uv run pre-commit run -a
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make check now runs uv run pre-commit ..., but pre-commit is not listed in pyproject.toml dependency groups and does not appear in uv.lock, so this target will likely fail in a fresh environment. Add pre-commit to the appropriate dependency group (and update uv.lock), or switch the Makefile to use a uv tool/uvx invocation so the tool is always available.

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed both issues:

  1. Added pre-commit>=3.0.0 to [dependency-groups] dev in pyproject.toml and updated uv.lock
  2. Updated CONTRIBUTING.md to reflect the uv + make install/check/test workflow (removed Poetry/tox references)

CI passes on all 3 Python versions.

Comment on lines 28 to +30
publish: ## publish a release to pypi.
@echo "🚀 Publishing: Dry run."
@poetry config pypi-token.pypi $(PYPI_TOKEN)
@poetry publish --dry-run
@echo "🚀 Publishing."
@poetry publish
@uv publish
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish target no longer uses PYPI_TOKEN (previously wired into Poetry) and now just runs uv publish, which will break existing workflows that relied on make publish picking up PYPI_TOKEN. Consider either mapping PYPI_TOKEN to whatever authentication mechanism uv publish expects (env var or config file), or adding an explicit check/error message when credentials are missing; also consider restoring an equivalent preflight/dry-run step if your release process depended on it.

Copilot uses AI. Check for mistakes.
Makefile Outdated
Comment on lines +9 to +10
@echo "🚀 Running code quality checks"
@uv run pre-commit run -a
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing Poetry/tox support, contributor guidance is now stale: CONTRIBUTING.md still instructs using poetry install/shell/run and running tox. Consider updating the contributing docs to reflect the uv + make install/check/test workflow so new contributors aren’t blocked.

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link
Contributor

Copilot AI commented Feb 7, 2026

@MrLYC I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you.

MrLYC and others added 4 commits February 8, 2026 00:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: 刘奕聪 <github@m.mrlyc.com>
Copy link
Contributor

Copilot AI commented Feb 7, 2026

@MrLYC I've opened a new pull request, #7, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 6 commits February 7, 2026 16:56
Co-authored-by: MrLYC <6391488+MrLYC@users.noreply.github.com>
Co-Authored-By: 刘奕聪 <github@m.mrlyc.com>
Co-authored-by: MrLYC <6391488+MrLYC@users.noreply.github.com>
Use `uv tool run` for pre-commit to avoid dependency declaration
Co-authored-by: MrLYC <6391488+MrLYC@users.noreply.github.com>
Update CONTRIBUTING.md to reflect uv migration from Poetry/tox
@MrLYC MrLYC merged commit db5b529 into main Feb 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants