Skip to content

Conversation

@casals
Copy link

@casals casals commented May 14, 2020

Can't bump to 6.X since 'findbugs' is deprecated after 5.6.4

Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nobody (@immortius ?) has any objections here - LGTM!

@keturn
Copy link
Member

keturn commented Jun 11, 2020

Would SpotBugs be an acceptable substitute for findbugs? that could be another issue, though.

@casals
Copy link
Author

casals commented Jun 11, 2020

Would SpotBugs be an acceptable substitute for findbugs? that could be another issue, though.

Actually, yes - findbugs is deprecated in gradle 6.x . I tried replacing it at first, but it also required a different config file, more changes in the script, etc - so I chose to bump the gradle version to the last one supporting findbugs for now (which solves the main problem of gradle being "too old").

@skaldarnar
Copy link
Member

Does any of you know how the back-and-forth porting is done here in gestalt - I think the change also makes sense for develop.

@keturn
Copy link
Member

keturn commented Sep 12, 2020

even with this branch, I get an error about not being able to find findbugs. Makes me doubt it's worth holding back on the gradle version in hopes of supporting it.

A problem occurred evaluating project ':gestalt'.
> Plugin with id 'findbugs' not found.

@casals
Copy link
Author

casals commented Sep 13, 2020

Actually FindBugs hasn't been developed since 2015, so it's more a matter of replacing it with SpotBugs (which uses a different syntax for configuration) or abandoning it at all. Nevertheless, FindBugs is working here with Gradle 5.6.4 - I double-checked the Gradle user guide and the plugin is supported up to version 5.6.x: https://docs.gradle.org/current/userguide/upgrading_version_5.html - perhaps triple-checking it with a fresh install/someone else + changing ti to develop as well (as skald suggested)

@Cervator
Copy link
Member

I did the things :-) #84 takes this a step further

@casals
Copy link
Author

casals commented Sep 13, 2020

Yay!! :D

@Cervator Cervator merged commit 27c833f into MovingBlocks:5.1.5 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants