Python3.8 remote - remove local tar files #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crayolakat
approved these changes
Aug 7, 2023
crayolakat
left a comment
crayolakat
left a comment
There was a problem hiding this comment.
Good flag! Yes, all the Dockerfiles can live in 1 branch now. Do you want to open that PR or me?
Author
|
I can – and to take this a step further... we could now just put the dockerfiles in each project repo! I just did that for the EA sync and it seems to work: https://github.com/MoveOnOrg/everyaction-syncs/commit/76b8c88c7cd5fde07ce2792e4277ebc65610fb5a |
|
Oh great! Should we still keep a copy of each Dockerfile in this repo as the "source of truth" or if we make changes to the dependencies/MoveOn custom additions, people know where to get the latest copy? |
Author
|
yeah that seems like a good plan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be able to remove local files now, avoiding needing
git-lfs.That said, we can probably just put these dockerfiles all in one
mainbranch now, right?