-
-
Notifications
You must be signed in to change notification settings - Fork 405
feat: Added i18n module with support for multiple languages #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
52fisher
wants to merge
3
commits into
Moustachauve:master
Choose a base branch
from
52fisher:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import en from './locales/en.js'; | ||
| import zh from './locales/zh.js'; | ||
|
|
||
| /** | ||
| * Internationalization class for handling multi-language support | ||
| */ | ||
| class I18n { | ||
| /** | ||
| * Constructor | ||
| */ | ||
| constructor() { | ||
| this.locales = { | ||
| en, | ||
| zh, | ||
| }; | ||
| this.currentLocale = this.getUserLocale(); | ||
| } | ||
|
|
||
| /** | ||
| * Get user's browser language setting | ||
| * @return {string} User's language code | ||
| */ | ||
| getUserLocale() { | ||
| // Try to get language from browser settings | ||
| const browserLocale = navigator.language || navigator.userLanguage; | ||
| const languageCode = browserLocale.split('-')[0]; | ||
|
|
||
| // Check if the language is supported | ||
| if (this.locales[languageCode]) { | ||
| return languageCode; | ||
| } | ||
|
|
||
| // Default to English | ||
| return 'en'; | ||
| } | ||
|
|
||
| /** | ||
| * Set current language | ||
| * @param {string} locale Language code | ||
| * @return {boolean} Whether the language was set successfully | ||
| */ | ||
| setLocale(locale) { | ||
| if (this.locales[locale]) { | ||
| this.currentLocale = locale; | ||
| return true; | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * Get translated text | ||
| * @param {string} key Translation key | ||
| * @param {string} defaultValue Default value | ||
| * @return {string} Translated text | ||
| */ | ||
| t(key, defaultValue = key) { | ||
| const locale = this.locales[this.currentLocale]; | ||
| return locale[key] || defaultValue; | ||
| } | ||
|
|
||
| /** | ||
| * Get supported languages | ||
| * @return {string[]} List of supported language codes | ||
| */ | ||
| getSupportedLocales() { | ||
| return Object.keys(this.locales); | ||
| } | ||
|
|
||
| /** | ||
| * Get current language | ||
| * @return {string} Current language code | ||
| */ | ||
| getCurrentLocale() { | ||
| return this.currentLocale; | ||
| } | ||
| } | ||
|
|
||
| // Export singleton instance | ||
| const i18n = new I18n(); | ||
| export default i18n; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the logical OR operator
||here can lead to incorrect behavior when a translation is an empty string (''). An empty string is a falsy value, solocale[key] || defaultValuewould incorrectly fall back to thedefaultValue(the translation key). An empty string can be a valid translation, for example, to intentionally hide a piece of text.To fix this, you should check for the existence of the key in the locale object more explicitly.