add fuzzy search, copy button, and bulk operations#322
add fuzzy search, copy button, and bulk operations#322levouinse wants to merge 4 commits intoMoustachauve:masterfrom
Conversation
Summary of ChangesHello @levouinse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the cookie management interface by integrating three key features: fuzzy search, a quick copy button for individual cookies, and comprehensive bulk operations. These additions aim to provide users with more efficient tools for identifying, manipulating, and managing their cookies, particularly useful for testing, debugging, or privacy-focused cleanup. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several useful features for cookie management, including a copy button and bulk operations for deleting and exporting cookies. The implementation of these features seems solid. However, the fuzzy search functionality, while the code has been added in cookieSearch.js, does not appear to be integrated into the cookie list filtering logic, so the existing simple text search is still being used. I've also identified a potential security vulnerability and a couple of areas for code cleanup.
interface/popup/cookie-list.js
Outdated
| document.addEventListener('click', e => { | ||
| if (e.target.id === 'selectAllCheckbox') { | ||
| handleSelectAll(); | ||
| } else if ( | ||
| e.target.id === 'bulkDelete' || | ||
| e.target.closest('#bulkDelete') | ||
| ) { | ||
| handleBulkDelete(); | ||
| } else if ( | ||
| e.target.id === 'bulkExport' || | ||
| e.target.closest('#bulkExport') | ||
| ) { | ||
| handleBulkExport(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This adds a third document.addEventListener('click', ...) to the file. For better maintainability and to avoid potential conflicts or ordering issues with event handlers, it's recommended to consolidate all document-level click listeners into a single one. You could merge the logic for handling bulk actions with the existing listeners for the main menu and export menu.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: levouinse <youlendse@gmail.com>
1 participant
Added three new features to improve cookie management:
Fuzzy Search
Copy Button
Bulk Operations
These features make it much faster to find and manage multiple cookies at once, especially useful when testing or cleaning up tracking cookies.
All changes are backward compatible and pass lint checks.