Combine other enrich #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- annotations - statistical_results from the parent class, enriched_result
we can get rid of the class specific combine method
- decided hypergeometric is better name than hypergeom - fixed all the documentation around that - and fixed all the testing that used "hypergeom" still need to fix those calls in the vignettes, and the CLI
as well as changes to the vignette so rebuilding them passes
updated values for gocats testing
…csLab/categoryCompare2 into combine_other_enrich
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues with the
enrichment_resultclass, adds a bunch of tests.