Open
Conversation
…enerate vertices) -> works
added 30 commits
June 2, 2020 16:06
not an ideal solution ..
finding a current bug (fixed in the following)
.. added the offset to early
actually need to decompress the blocks one by one .. (see `morph_saving_offsets_test` for reasoning) Lead to a couple of changes: * morph_saving_offsets now accepts column_with_offsets as input * dedicated morph_saving_offset for decompression
* changing cache in csr -> not const function anymore
catching a current bug regarding the offset_column (not fixing it yet) Failure case: last vertex has no edges -> no edges added -> no offset set
slimming down graph.h unique ptr didn't make sense, as the algorithm does not own the graph here
use-case: bfs_benchmark
for evaluating impact of graph compressions
and correcting the number of block-offsets to be reserved
looks like the ldbc graph schema is not final .. they added a forum type in the dev branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result of two consecutive projects (first one by @TimPF).
Also lifts the needed C++ version to 17.
It might make sense to introduce an
graphbuild flag.