Creates a simple MySQL database#9
Open
stevemac1900 wants to merge 17 commits intoMoravianUniversity:masterfrom
Open
Creates a simple MySQL database#9stevemac1900 wants to merge 17 commits intoMoravianUniversity:masterfrom
stevemac1900 wants to merge 17 commits intoMoravianUniversity:masterfrom
Conversation
All data is stored in one table since I am making all fields directly dependent on the id field.
Adding a datetime field necessitated two tables, one for static information and one for variable. It also means we will need indexing since we will be storing significantly more data. The size field, upon further inspection, actually holds the information for 2 or 3 fields depending whether the entry is for kegs or cans/bottles. This has been split into 3 separate fields - containers_per_pack, container_size and container_type. Additionally the case_pack field has been renamed to better reflect the values being stored there.
Contributor
Author
|
Should I make unit tests for this or is it simple enough that it doesn't need any? I started looking into unit test suites for MySQL, this one is open source, looks like it might do the trick. Would we need any special permissions or anything to use this? |
…nd add more documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All data is stored in one table since I am making all fields directly dependent on
the id field.