Open
Conversation
MoyanZitto
reviewed
Jun 24, 2025
| if isinstance(wav_path_or_waveform, str): | ||
| wav_tokens = self.audio_tokenizer.tokenize(audio_path=wav_path_or_waveform) | ||
| else: | ||
| wav_tokens = self.audio_tokenizer.tokenize(speech=wav_path_or_waveform) |
Collaborator
There was a problem hiding this comment.
这种情况下好像没办法保证wav_path_or_waveform一定sr=16000，如果用错了会有难发现的bug（能正常推但是结果不对）
感觉可以来个org_sr，当wav_path_or_waveform是一个ndarray / tensor的时候，要求同时提供一下这个wavform对应的sr，这样我们可以里面resample一下？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support using waveform as input besides audio path.
Discussion in #124 .