Open
Conversation
horsekitlin
reviewed
Aug 25, 2018
| } | ||
| }) | ||
| } | ||
| getOrderList = async () => { |
Contributor
There was a problem hiding this comment.
(建議)
setOrderListData = ({items, paging) =>
this.setState({orderListData: { items, paging });
horsekitlin
reviewed
Aug 25, 2018
| </Table.Header> | ||
|
|
||
| <Table.Body> | ||
| { |
Contributor
There was a problem hiding this comment.
body 可以拆出去做一個 component
之後列表的 rerender 比較好優化
另外也可以用命名表示這個部分是什麼
如果真的要看細節再點進去看
Ex: OrderListContent, OrderListBody ....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.