-
Notifications
You must be signed in to change notification settings - Fork 38
ener_lib: fix for sp2 nitrogen #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hb_types and missing explanations
|
N8 of ZPA should be NH0 We should correct ener_lib and add some more. @flong-mrc I think acedrg should be adjusted also |
|
I see these NR* types are for aromatic atoms, while it's not documented. We would need only five types for sp2 nitrogen (N20 and N21 are the new addition, and we can make all others obsolete). Please review the updated file. I believe Fei has already updated Acedrg (not committed yet) to support these types. |
|
Just for records: HB type of N21 (sp2 N with two bonds attached to one hydrogen atoms) should be B (both acceptor and donor) |
|
Corrected! |
GaribMurshudov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks fine now
|
Could you approve this? |
|
Done ( I think) |
GaribMurshudov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me now.
Explanations were added for NR55/NR56/NR66. Now here is the list of sp2 nitrogen atom types:
And the hb_type was changed to N (neither) for NR5/NR6/NR55/NR56. Examples are
The current monomer library has a problem of nitrogen atom types and they need to be updated.