Skip to content

Conversation

@AristurtleDev
Copy link
Collaborator

Description

When #724 was implemented, it added the call to CreateComponentBits during the OnComponentsChanged event to resolve issue #723. However, in doing so, this made it so that CreateComponentBits is called a again during Update when it doesn't need to be. This call should have been removed.

Related Issues/Tickets

Changes Made

  • Removed call to CreateComponentBits in Update method for changed entities.

Checklist

Please read and check the following items. Pull requests will not be reviewed if all items are not checked.

  • I have verified that there are no existing pull requests that would overlap with this pull request.
  • I have verified that I am following the guidelines as outlined in this project's contribution policy
  • I have verified that this pull request adheres to this project's code of conduct.
  • I have written a descriptive title for this pull request.
  • I have provided appropriate test coverage were applicable.

@AristurtleDev AristurtleDev self-assigned this Nov 11, 2025
@AristurtleDev AristurtleDev added Status: Completed Work finished Type: Enhancement Improvement to existing feature Area: Performance Performance improvements Platform: Cross-platform All platforms labels Nov 11, 2025
@AristurtleDev AristurtleDev merged commit 25c3cff into develop Nov 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Performance Performance improvements Platform: Cross-platform All platforms Status: Completed Work finished Type: Enhancement Improvement to existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible Duplicate Call to CreateComponentBits in EntityManager.OnComponentsChanged

2 participants