Slimegirl's Requiem: slimeperson refactoring and improvements!#86
Open
Absolucy wants to merge 65 commits intoMonkestation:masterfrom
Open
Slimegirl's Requiem: slimeperson refactoring and improvements!#86Absolucy wants to merge 65 commits intoMonkestation:masterfrom
Absolucy wants to merge 65 commits intoMonkestation:masterfrom
Conversation
…into slimegirls-requiem
…ule to `oozelings`, despite the fact they're not called that here, to reduce confusion. maybe i should rename it to `slimegirl_requiem` or `roundstartslime2` lol
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
… DME CONFLICTS DME CONFLICTS DME CONFLICTS DME CONFLICTS DME CONFLICTS DME CONFLICTS DME CONFLICTS DME CONFLICTS DME CONFLICTS
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
…into slimegirls-requiem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
still very WIP / todoready for testing at least, albeit still have some stuff to do.This ports a lot of Monke's improvements for jellypeople (including roundstart slimes):
TRAIT_NOFIRE, given that uh, being extinguished is bad for themsee changelog tbh
Why it's Good for the Game
Makes slimepeople way less buggy and more consistent in general, deshittifying a lot of the Nova code.
Proof of Testing
Changelog
🆑 Absolucy, Siro
fix: Reviving slimepeople cores should now be far more reliable.
add: Slimepeople cores now store their items in them when they die.
add: You can either use the core in-hand to take all the items out and disable the GPS signal, or double-examine it to see what individual items a core contains, and fetch them from the core.
add: Added an ability for dead slimepeople, "Membrane Murmur", allowing them to vocalize a short-range cry for help from their core every so often.
qol: Slimepeople that are special revived not in a nugget state will reequip their items automatically.
balance: Water vapor now affects slimepeople. Starting at 1kPa partial pressure it will do lung and blood damage. Max damage occurs at 8kPa. Hydrophobia does not protect against this.
qol: Slime Washing now eats grime off the floor when moving, not just every second.
qol: Slime Washing now works if the user is lying down, even if they have shoes on.
qol: Slimepeople now have their core signal on by default.
fix: Fixed the GPS name of slimepeople core being "Unknown's Core" sometimes.
balance: Slimepeople can no longer catch on fire... since, well, you can't really fire extinguish them, can you?
balance: Slimepeople now need less oxygen to breathe. They still need SOME, and they still need pressure, but like, they need slightly less.
qol: Trying to pour plasma on a DNR slime core will just tell you that their soul has departed.
balance: Basic mask filters can prevent breathing in of water vapor.
fix: Rescue hooks can now fish up slime cores.
balance: Water exposure, i.e fire extinguishers, is now bad for slimepeople. This can be mitigated with thick clothing (such as modsuits), or the Hydrophobia ability (at the cost of notable slowdown)
admin: Added a "Heal Slime Core" verb for admins.
balance: Slimepeople can no longer regenerate limbs if they have Hydrophobia active - turn off Hydrophobia to regenerate your limbs!
/:cl: