Report errors detected in SBML when parsing #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the checkSBMLDocument function in SBMLLint/common/util.py would check if the error count during parsing of the document was non-zero and raise a ValueError if so. This change still raises a ValueError, but it adds the contents of the python-libsml error log to the ValueError to the message parameter to enable users to identify and correct parsing errors. In addition, this change modifies the lint function in SBMLLint/tools/sbmllint.py to pass the name of the SBML file that is currently being parsed to the call to checkSBMLDocument so that the ValueError can report the model filename in the expression parameter, rather than an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the checkSBMLDocument function in
SBMLLint/common/util.py would check if the error count during parsing
of the document was non-zero and raise a ValueError if so. This
change still raises a ValueError, but it adds the contents of
the python-libsml error log to the ValueError to the message
parameter to enable users to identify and correct parsing errors.
In addition, this change modifies the lint function in
SBMLLint/tools/sbmllint.py to pass the name of the SBML file that
is currently being parsed to the call to checkSBMLDocument so that
the ValueError can report the model filename in the expression
parameter, rather than an empty string.