Feat: pr 리뷰 요청 글 전체 조회 api 단 구현 #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seobbang
reviewed
Nov 29, 2025
|
|
||
| export async function queryPrReviews(params?: QueryPrReviewsQueryParams): Promise<ApiResponse<QueryPrReviewsResponse>> { | ||
| return apiClient.get<QueryPrReviewsResponse>("api/v1/pr-reviews", { | ||
| searchParams: params as Record<string, string | number>, |
Member
There was a problem hiding this comment.
요기 단언 들어가야하는거 되게 특이하네요,,, 그럼 searchParams 넘겨줄 때마다 단언이 필요하다니
Suggested change
| searchParams: params as Record<string, string | number>, | |
| searchParams: {...params} |
object literal로 추론하게 요런 방법도 있네요 ㅎㅎㅎ..
Member
There was a problem hiding this comment.
Suggested change
searchParams: params as Record<string, string | number>, searchParams: {...params} object literal로 추론하게 요런 방법도 있네요 ㅎㅎㅎ..
호오 리터럴로 추론하는 방법 좋은데요?!
| isLast: boolean; | ||
| } | ||
|
|
||
| export async function queryPrReviews(params?: QueryPrReviewsQueryParams): Promise<ApiResponse<QueryPrReviewsResponse>> { |
| import { prListQueryKeys } from "./querykeys"; | ||
|
|
||
| export const useQueryPrReviews = (params?: QueryPrReviewsQueryParams) => { | ||
| return useQuery<ApiResponse<QueryPrReviewsResponse>, Error>({ |
Member
There was a problem hiding this comment.
Suggested change
| return useQuery<ApiResponse<QueryPrReviewsResponse>, Error>({ | |
| return useQuery({ |
요기도 추론돼서 없어도 괜찮을 것 같아욤
jungwoo3490
approved these changes
Dec 7, 2025
|
|
||
| export async function queryPrReviews(params?: QueryPrReviewsQueryParams): Promise<ApiResponse<QueryPrReviewsResponse>> { | ||
| return apiClient.get<QueryPrReviewsResponse>("api/v1/pr-reviews", { | ||
| searchParams: params as Record<string, string | number>, |
Member
There was a problem hiding this comment.
Suggested change
searchParams: params as Record<string, string | number>, searchParams: {...params} object literal로 추론하게 요런 방법도 있네요 ㅎㅎㅎ..
호오 리터럴로 추론하는 방법 좋은데요?!
Comment on lines
+27
to
+29
| status: string; | ||
| /** 분야 태그 */ | ||
| position: string; |
Member
There was a problem hiding this comment.
요기 QueryPrReviewsQueryParams로 넘길 수 있는 값이랑 같으면 타입 좁혀줘도 좋을 것 같아요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #22
☑️ 완료 태스크
🔎 PR 내용
공통 사용 부분인 PR 리뷰 요청 글 전체 조회 (
QueryPrReviews) api 단 구현한 PR 먼저 main에 반영합니다> PR 리뷰 요청 글 전체 조회 API 명세
api hook 사용부 example
📷 스크린샷
2025-11-28.00.34.05.mov