Add support for multiple NICs and specifying which local IP to bind the server to.#20
Open
PhonicUK wants to merge 2 commits intoMirrorNetworking:masterfrom
Open
Add support for multiple NICs and specifying which local IP to bind the server to.#20PhonicUK wants to merge 2 commits intoMirrorNetworking:masterfrom
PhonicUK wants to merge 2 commits intoMirrorNetworking:masterfrom
Conversation
Allow the server to have a local IP binding specified. Remains API compatible as the new param is optional and reverts to the same original default (v6Any)
Allows (in code) the local IP that the server will bind against to be specified for servers with multiple IPs.
miwarnec
force-pushed
the
master
branch
3 times, most recently
from
6f47d9c to
6900bf2
Compare
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
b31337a to
38b3ac4
Compare
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
e65e85b to
6baf722
Compare
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
4e43d57 to
a18854b
Compare
miwarnec
force-pushed
the
master
branch
3 times, most recently
from
d6ae9fe to
eeb25ed
Compare
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
ec826db to
5e2ef37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On servers with multiple NICs it may be necessary or desirable to bind a server to a specific one of them instead of listening on all available NICs.
I've added the ability to do this to the KCPTransport. Now you can do:
Because of the way it uses an optional parameter and a field that initialises with the same value, this is an API compatible drop-in change.