Skip to content

fixing condition to raise exception when URL is not reachable [Fixes #9] #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DheerajDang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixing condition to raise exception when URL is not reachable [Fixes #9] #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 26 additions & 25 deletions rally_plugins/scenarios/kubernetes/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,32 +229,33 @@ def run(self, image, port, protocol, image_pull_policy='IfNotPresent',
else:
ip = "://" + server[:server.index(":") + 1]
url = ("http" + ip + str(node_port) + "/")
while i < retries_total:
try:
kwargs = {}
if request_timeout:
kwargs["timeout"] = request_timeout
requests.get(url, **kwargs)
except (requests.ConnectionError, requests.ReadTimeout) as ex:
if i < retries_total:
i += 1
commonutils.interruptable_sleep(sleep_time)
try:
while i < retries_total:
try:
kwargs = {}
if request_timeout:
kwargs["timeout"] = request_timeout
requests.get(url, **kwargs)
except (requests.ConnectionError, requests.ReadTimeout) as ex:
if i < retries_total:
i += 1
commonutils.interruptable_sleep(sleep_time)
if i == retries_total:
raise exceptions.RallyException(
message="Unable to get response "
"from %(url)s: %(ex)s" % {
"url": url,
"ex": str(ex)
})
else:
raise exceptions.RallyException(
message="Unable to get response "
"from %(url)s: %(ex)s" % {
"url": url,
"ex": str(ex)
})
else:
break

self.client.delete_service(name, namespace=namespace)
self.client.delete_pod(
name,
namespace=namespace,
status_wait=status_wait
)
break
finally:
self.client.delete_service(name, namespace=namespace)
self.client.delete_pod(
name,
namespace=namespace,
status_wait=status_wait
)


@scenario.configure(
Expand Down