[release/0.3] Use SHA256 to digest the seccomp profile #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MD5 hash algorithm panics under GODEBUG=fips140=only. Calculate the digest of the seccomp profile using SHA256 instead. The message containing the digest is informational only so changing the hash algorithm should not introduce any compatibility breaks. And as far as I can tell the DockerOpt.msg field is a dead store so this change should have no observable impact on behaviour aside from not panicking when run in FIPS140-only mode. Signed-off-by: Cory Snider <csnider@mirantis.com> (cherry picked from commit e91fb78) Signed-off-by: Cory Snider <csnider@mirantis.com>
yevchuk-kostiantyn
approved these changes
Dec 18, 2025
Contributor
yevchuk-kostiantyn
left a comment
yevchuk-kostiantyn
left a comment
There was a problem hiding this comment.
LGTM, thanks!
athongsamai
approved these changes
Jan 5, 2026
smerkviladze
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MD5 hash algorithm panics under GODEBUG=fips140=only. Calculate the digest of the seccomp profile using SHA256 instead. The message containing the digest is informational only so changing the hash algorithm should not introduce any compatibility breaks. And as far as I can tell the DockerOpt.msg field is a dead store so this change should have no observable impact on behaviour aside from not panicking when run in FIPS140-only mode.