Skip to content

GEOPY-2439: Dask.distributed crash on compute source term for large ATEM survey #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 4 commits into from
Sep 12, 2025
Merged

GEOPY-2439: Dask.distributed crash on compute source term for large ATEM survey #116

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74fd61c
Try halving the threads
domfournier Sep 9, 2025
0c95921
TRy with a flat list of sources
domfournier Sep 10, 2025
8bce08b
Temp remove of parallel process
domfournier Sep 10, 2025
c9c2188
Clean out comments
domfournier Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 8 additions & 46 deletions simpeg/dask/electromagnetics/time_domain/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,47 +62,9 @@ def getSourceTerm(self, tInd):
elif getattr(self, "_stashed_sources", None) is None:
self._stashed_sources = {}

try:
client = get_client()
sim = client.scatter(self, workers=self.worker)
except ValueError:
client = None
sim = self

source_list = self.survey.source_list
source_block = np.array_split(
np.arange(len(source_list)), self.n_threads(client=client)
)

if client:
sim = client.scatter(self, workers=self.worker)
source_list = client.scatter(source_list, workers=self.worker)
else:
delayed_source_eval = delayed(source_evaluation)
sim = self

block_compute = []
for block in source_block:
if client:
block_compute.append(
client.submit(
source_evaluation,
sim,
block,
self.times[tInd],
source_list,
workers=self.worker,
)
)
else:
block_compute.append(
delayed_source_eval(self, block, self.times[tInd], source_list)
)

if client:
blocks = client.gather(block_compute)
else:
blocks = dask.compute(block_compute)[0]
blocks = []
for source in self.survey.source_list:
blocks.append(source_evaluation(self, self.times[tInd], source))

s_m, s_e = [], []
for block in blocks:
Expand Down Expand Up @@ -283,12 +245,12 @@ def field_projection(field_array, src_list, array_ind, time_ind, func):
return new_array


def source_evaluation(simulation, indices, time_channel, sources):
def source_evaluation(simulation, time_channel, source):
s_m, s_e = [], []
for ind in indices:
sm, se = sources[ind].eval(simulation, time_channel)
s_m.append(sm)
s_e.append(se)

sm, se = source.eval(simulation, time_channel)
s_m.append(sm)
s_e.append(se)

return s_m, s_e

Expand Down