Skip to content

Conversation

@sebhmg
Copy link

@sebhmg sebhmg commented Aug 14, 2025

No description provided.

@sebhmg sebhmg requested review from Copilot and saicheranb August 14, 2025 03:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates GitHub Actions workflows to improve JIRA integration security and restrict execution to the main repository. The changes transition from deprecated authentication methods and prevent workflows from running on repository forks.

Key changes:

  • Switched from pull_request_target to pull_request trigger for better security
  • Updated JIRA authentication from basic auth to API token-based authentication
  • Added repository restrictions to prevent workflow execution on forks

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/pr_add_jira_summary.yml Updated trigger type, added fork restriction, and migrated to API token authentication
.github/workflows/issue_to_jira.yml Added fork restriction to prevent execution on repository forks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


on:
pull_request_target: # zizmor: ignore[dangerous-triggers]
pull_request:
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from 'pull_request_target' to 'pull_request' may introduce security risks. The 'pull_request_target' trigger runs in the context of the target repository with access to secrets, while 'pull_request' runs in the context of the fork without secret access. If this workflow requires access to JIRA secrets, it will fail when triggered by pull requests from forks.

Suggested change
pull_request:
pull_request_target:

Copilot uses AI. Check for mistakes.
@sebhmg
Copy link
Author

sebhmg commented Aug 14, 2025

will try again another PR from fork

@sebhmg sebhmg closed this Aug 14, 2025
@sebhmg
Copy link
Author

sebhmg commented Aug 14, 2025

see #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant