Skip to content

GEOPY-2624: check for MVI Simpeg groups and raise error #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebhmg merged 2 commits into from
Dec 5, 2025
Merged

GEOPY-2624: check for MVI Simpeg groups and raise error #326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3823719
check for MVI Simpeg groups and raise error
benk-mira Dec 3, 2025
19e953d
Merge branch 'release/ga-4.7' into GEOPY-2624
MatthieuCMira Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions simpeg_drivers/joint/joint_surveys/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
from pathlib import Path
from typing import ClassVar

from geoapps_utils.utils.importing import GeoAppsError
from pydantic import model_validator
from pydantic import field_validator, model_validator

from simpeg_drivers import assets_path
from simpeg_drivers.joint.options import BaseJointOptions
Expand All @@ -35,6 +34,19 @@ class JointSurveysOptions(BaseJointOptions):

models: ConductivityModelOptions

@field_validator("group_a", "group_b", "group_c")
@classmethod
def no_mvi_groups(cls, val):
if val is None:
return val

if "magnetic vector" in val.options.get("inversion_type", ""):
raise ValueError(
f"Joint inversion doesn't currently support MVI data as passed in "
f"the group: {val.name}."
)
return val

@model_validator(mode="after")
def all_groups_same_physical_property(self):
physical_properties = [k.options["physical_property"] for k in self.groups]
Expand Down