Skip to content

Conversation

@benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Nov 14, 2024

GEOPY-1820 - Add a depth of investigation application

@github-actions github-actions bot changed the title Geopy 1820 GEOPY-1820: Add a depth of investigation application Nov 14, 2024
@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.55%. Comparing base (43ee249) to head (c95ca20).
Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
...epth_of_investigation/sensitivity_cutoff/driver.py 89.28% 2 Missing and 1 partial ⚠️
...epth_of_investigation/sensitivity_cutoff/params.py 86.95% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #105      +/-   ##
===========================================
- Coverage    91.58%   91.55%   -0.03%     
===========================================
  Files           89       91       +2     
  Lines         5241     5294      +53     
  Branches       550      552       +2     
===========================================
+ Hits          4800     4847      +47     
- Misses         312      317       +5     
- Partials       129      130       +1     
Files with missing lines Coverage Δ
...drivers/components/factories/directives_factory.py 95.21% <100.00%> (+0.04%) ⬆️
...epth_of_investigation/sensitivity_cutoff/driver.py 89.28% <89.28%> (ø)
...epth_of_investigation/sensitivity_cutoff/params.py 86.95% <86.95%> (ø)
---- 🚨 Try these New Features:

Copy link
Collaborator

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I realized that the sensivities saved on file are JtJ diag, which would be ~J**2.
Let's add a transform to the save directive to square root those.

   `kwargs["transforms"].append(lambda x: x ** 0.5)`

@benk-mira
Copy link
Contributor Author

Looks good. I realized that the sensivities saved on file are JtJ diag, which would be ~J**2. Let's add a transform to the save directive to square root those.

   `kwargs["transforms"].append(lambda x: x ** 0.5)`

Updated

benk-mira and others added 6 commits November 21, 2024 12:04
…r.py

Co-authored-by: domfournier <dominiquef@mirageoscience.com>
…r.py

Co-authored-by: domfournier <dominiquef@mirageoscience.com>
…r.py

Co-authored-by: domfournier <dominiquef@mirageoscience.com>
@domfournier domfournier merged commit 8f951bd into develop Nov 21, 2024
10 checks passed
@domfournier domfournier deleted the GEOPY-1820 branch November 21, 2024 22:56
@benk-mira benk-mira restored the GEOPY-1820 branch November 22, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants