-
Notifications
You must be signed in to change notification settings - Fork 2
GEOPY-1820: Add a depth of investigation application #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #105 +/- ##
===========================================
- Coverage 91.58% 91.55% -0.03%
===========================================
Files 89 91 +2
Lines 5241 5294 +53
Branches 550 552 +2
===========================================
+ Hits 4800 4847 +47
- Misses 312 317 +5
- Partials 129 130 +1
|
domfournier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I realized that the sensivities saved on file are JtJ diag, which would be ~J**2.
Let's add a transform to the save directive to square root those.
`kwargs["transforms"].append(lambda x: x ** 0.5)`
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/driver.py
Outdated
Show resolved
Hide resolved
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/driver.py
Outdated
Show resolved
Hide resolved
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/driver.py
Outdated
Show resolved
Hide resolved
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/params.py
Outdated
Show resolved
Hide resolved
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/params.py
Outdated
Show resolved
Hide resolved
Updated |
… to the add_data call
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/driver.py
Outdated
Show resolved
Hide resolved
…ed sensitivity save since it's done in the saveiteration now.
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/driver.py
Outdated
Show resolved
Hide resolved
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/driver.py
Outdated
Show resolved
Hide resolved
…r.py Co-authored-by: domfournier <dominiquef@mirageoscience.com>
…r.py Co-authored-by: domfournier <dominiquef@mirageoscience.com>
…r.py Co-authored-by: domfournier <dominiquef@mirageoscience.com>
GEOPY-1820 - Add a depth of investigation application