-
Notifications
You must be signed in to change notification settings - Fork 0
added zizmor security to workflow #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates a Zizmor security scan into the CI pipeline and tightens permissions on several workflows.
- Add a Zizmor security scan job to
static-analysis.yml - Specify granular
permissionsinpytest-unix-os.yml,pr_add_jira_summary.yml, andissue_to_jira.yml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/static-analysis.yml | Add new zizmor-security-scan job for security analysis |
| .github/workflows/pytest-unix-os.yml | Declare permissions for contents and pull requests |
| .github/workflows/pr_add_jira_summary.yml | Declare permissions for contents and pull requests |
| .github/workflows/issue_to_jira.yml | Declare permissions for contents and issues |
Comments suppressed due to low confidence (3)
.github/workflows/static-analysis.yml:90
- This new job is missing a required runner definition. Please add a
runs-onfield (e.g.,runs-on: ubuntu-latest) under this job to ensure it executes.
zizmor-security-scan:
.github/workflows/pytest-unix-os.yml:4
- The permission key
pull-requestsis invalid; usepull_requests: writeto match GitHub Actions permission syntax.
pull-requests: write
.github/workflows/pr_add_jira_summary.yml:7
- The permission key
pull-requestsis invalid; usepull_requests: writefor correct GitHub Actions syntax.
pull-requests: write
…mprove credential handling
…y workflow reference
…analysis and pytest workflows
…analysis workflow
…ions, and improving file capture logic
…d enhance job configurations
…file capture logic, and refine job configurations
…ile capture logic, and standardize job configurations
…tput parameters for modified files
…d improve environment setup
…ssue key extraction logic
…ine checkout and setup steps in pytest workflows
…able and adjust file capture logic
…or multi-line environment variable
…n static analysis workflow
|
this went to the wrong branch (to main instead of develop). See Zizmor applied in #27 |
No description provided.