Skip to content

Conversation

@MatthieuCMira
Copy link
Contributor

@MatthieuCMira MatthieuCMira commented Dec 19, 2025

GEOPY-2591 - geoimage/grid2d conversion of non rectangular geoimage
avoid more bugs with geoimage:

1/ georeferencing now acts normaly. (however tie points must meet certain conditions)

2/ more protections to convert to grid2d

3/ add unittests

Matthieu Cedou added 4 commits December 18, 2025 13:57
getting there
change the tests
I also tested a bit with real data and it's seems good.

Good luck for testing exhaustively.... :-/
@github-actions github-actions bot changed the title Geopy 2591 GEOPY-2591: geoimage/grid2d conversion of non rectangular geoimage Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 96.55172% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.10%. Comparing base (9a2627c) to head (bb829e5).

Files with missing lines Patch % Lines
geoh5py/objects/geo_image.py 97.11% 2 Missing and 1 partial ⚠️
geoh5py/shared/utils.py 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #826      +/-   ##
===========================================
+ Coverage    91.07%   91.10%   +0.03%     
===========================================
  Files          115      115              
  Lines        10118    10222     +104     
  Branches      1877     1899      +22     
===========================================
+ Hits          9215     9313      +98     
- Misses         481      486       +5     
- Partials       422      423       +1     
Files with missing lines Coverage Δ
geoh5py/shared/conversion/geo_image.py 85.93% <100.00%> (+3.24%) ⬆️
geoh5py/shared/cut_by_extent.py 92.10% <100.00%> (+0.15%) ⬆️
geoh5py/shared/utils.py 91.80% <92.30%> (+0.02%) ⬆️
geoh5py/objects/geo_image.py 96.73% <97.11%> (+1.00%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants