GEOPY-2591: geoimage/grid2d conversion of non rectangular geoimage #826
Conversation
getting there
change the tests
I also tested a bit with real data and it's seems good. Good luck for testing exhaustively.... :-/
github-actions
bot
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #826 +/- ##
===========================================
+ Coverage 91.07% 91.17% +0.09%
===========================================
Files 115 115
Lines 10119 10240 +121
Branches 1877 1903 +26
===========================================
+ Hits 9216 9336 +120
- Misses 481 482 +1
Partials 422 422
🚀 New features to boost your workflow:
|
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
Just a few comments, looks great!
geoh5py/objects/geo_image.py
Outdated
| Compute world coordinates of image corners from 2 tie points, | ||
| assuming: | ||
| - rotation (yaw) = 0, | ||
| - dip direction = v (pixel j), | ||
| - x = f(i), y = g(j), z = h(j) (no shear). |
There was a problem hiding this comment.
I don't really understand the logic here. I would think it is possible to stretch and orient any two pixels in space be defining there coordinates in 3D space. The stretch will have to be isometric, and can only define two angles, but i don't see why need the i's and the j's to be different... something like this
There was a problem hiding this comment.
1- Define what the pixel size has to be based on pixel_distance / real_distance (isometric)
2- Define an azimuth and dip angles defining the vector connecting the two points
3- Apply the transfomation (shift, stretch + rotations) to the four corners.
Maybe?
There was a problem hiding this comment.
In this figure, are we agreeing the image can be infinitely rotated along the axis defined by the 2 points right?
GEOPY-2591 - geoimage/grid2d conversion of non rectangular geoimage
avoid more bugs with geoimage:
1/ georeferencing now acts normaly. (however tie points must meet certain conditions)
2/ more protections to convert to grid2d
3/ add unittests