-
Notifications
You must be signed in to change notification settings - Fork 12
GEOPY-2492: Support FloatRangeSlider as geoh5py form #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
# Conflicts: # geoh5py/ui_json/forms.py # tests/ui_json/forms_test.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #823 +/- ##
========================================
Coverage 91.07% 91.08%
========================================
Files 115 115
Lines 10118 10126 +8
Branches 1877 1878 +1
========================================
+ Hits 9215 9223 +8
Misses 481 481
Partials 422 422
🚀 New features to boost your workflow:
|
MatthieuCMira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some equestion and minor changes
geoh5py/ui_json/forms.py.orig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file from a merge conflict.. removed
MatthieuCMira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I<ll approve.
Still, don't hesitate to add more docstrings with params and all
GEOPY-2492 - Support FloatRangeSlider as geoh5py form