GEOPY-2525: Support placeholderText in uijson forms #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #811 +/- ##
========================================
Coverage 91.07% 91.07%
========================================
Files 115 115
Lines 10118 10119 +1
Branches 1877 1877
========================================
+ Hits 9215 9216 +1
Misses 481 481
Partials 422 422
🚀 New features to boost your workflow:
|
domfournier
previously approved these changes
Nov 18, 2025
domfournier
reviewed
Nov 20, 2025
geoh5py/ui_json/forms.py
Outdated
| dependency_type: DependencyType = DependencyType.ENABLED | ||
| group_dependency: str = "" | ||
| group_dependency_type: DependencyType = DependencyType.ENABLED | ||
| place_holder_text: str = "" |
Contributor
There was a problem hiding this comment.
Something is missing here to convert the alias "placeholderText" to snake_case. I think it should be placeholder_text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOPY-2525 - Support placeholderText in uijson forms