Skip to content

Conversation

@benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Nov 18, 2025

GEOPY-2525 - Support placeholderText in uijson forms

@github-actions github-actions bot changed the title GEOPY-2525 GEOPY-2525: Support placeholderText in uijson forms Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.86%. Comparing base (1a8c416) to head (616da8e).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #811      +/-   ##
===========================================
- Coverage    90.88%   90.86%   -0.02%     
===========================================
  Files          113      113              
  Lines         9873     9875       +2     
  Branches      1838     1838              
===========================================
  Hits          8973     8973              
- Misses         487      488       +1     
- Partials       413      414       +1     
Files with missing lines Coverage Δ
geoh5py/ui_json/forms.py 95.87% <100.00%> (+0.02%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

domfournier
domfournier previously approved these changes Nov 18, 2025
dependency_type: DependencyType = DependencyType.ENABLED
group_dependency: str = ""
group_dependency_type: DependencyType = DependencyType.ENABLED
place_holder_text: str = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is missing here to convert the alias "placeholderText" to snake_case. I think it should be placeholder_text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants