GEOPY-2508: Add multi-select data form type #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue form types to reduce complexity
# Conflicts: # geoh5py/ui_json/forms.py # geoh5py/ui_json/ui_json.py
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #810 +/- ##
===========================================
- Coverage 91.09% 91.02% -0.07%
===========================================
Files 114 115 +1
Lines 10072 10118 +46
Branches 1869 1877 +8
===========================================
+ Hits 9175 9210 +35
- Misses 480 485 +5
- Partials 417 423 +6
🚀 New features to boost your workflow:
|
domfournier
commented
Nov 18, 2025
MatthieuCMira
requested changes
Dec 15, 2025
Contributor
MatthieuCMira
left a comment
MatthieuCMira
left a comment
There was a problem hiding this comment.
In general, extend the docstrings (I did not add a comment for every not documented docstring).
In the MCP Era, we want everything well documented! ;-)
some comments, but they are not mandatory. I'll let you the choice to implement them or not
…a fixture from within a fixture, so I replaced the old mechanic of passing tmp_path into a function that creates data with a fixture (tmp_path) in a fixture (sample_uijson).
Contributor
|
ok, so basically everything will be done latter? Ok, I'll approve then. |
MatthieuCMira
previously approved these changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
everything will be done latter...
GEOPY-2632, GEOPY-260, GEOPY-2492
Maybe link those issues in JIRA?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOPY-2508: Add multi-select data form type