Skip to content

Conversation

@domfournier
Copy link
Contributor

@domfournier domfournier commented Nov 13, 2024

GEOPY-1840 - Enforce reference data type shared between the tx_id_property of receiver and complement (transmitter, base station)

@github-actions github-actions bot changed the title GEOPY-1840 GEOPY-1840: Enforce reference data type shared between the tx_id_property of receiver and complement (transmitter, base station) Nov 13, 2024
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (c8e8fad) to head (3b4165e).
Report is 4 commits behind head on release/0.10.0.

Files with missing lines Patch % Lines
geoh5py/objects/surveys/electromagnetics/tipper.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/0.10.0     #666      +/-   ##
==================================================
- Coverage           90.76%   90.75%   -0.01%     
==================================================
  Files                 105      105              
  Lines                8953     8960       +7     
  Branches             1670     1673       +3     
==================================================
+ Hits                 8126     8132       +6     
+ Misses                445      443       -2     
- Partials              382      385       +3     
Files with missing lines Coverage Δ
geoh5py/objects/surveys/electromagnetics/base.py 86.91% <100.00%> (-0.32%) ⬇️
geoh5py/objects/surveys/electromagnetics/tipper.py 90.10% <66.66%> (-0.80%) ⬇️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@MatthieuCMira MatthieuCMira self-requested a review November 13, 2024 21:26
Copy link
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for me.
Can you just explain a bit why we need to passe the entity_type for IntegerData?
Thanks

@domfournier domfournier merged commit e4d8ccc into release/0.10.0 Nov 19, 2024
12 checks passed
@domfournier domfournier deleted the GEOPY-1840 branch November 19, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants