Skip to content

Conversation

@MatthieuCMira
Copy link
Contributor

@MatthieuCMira MatthieuCMira commented Nov 13, 2024

GEOPY-1846 - pass drillholes group in InputFile data

@github-actions github-actions bot changed the title Geopy 1846 GEOPY-1846: pass drillholes group in InputFile data Nov 13, 2024
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (33955d1) to head (8346743).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
geoh5py/ui_json/input_file.py 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #665   +/-   ##
========================================
  Coverage    90.85%   90.86%           
========================================
  Files          107      107           
  Lines         8981     8999   +18     
  Branches      1678     1685    +7     
========================================
+ Hits          8160     8177   +17     
- Misses         441      442    +1     
  Partials       380      380           
Files with missing lines Coverage Δ
geoh5py/shared/concatenation/concatenator.py 89.30% <ø> (ø)
geoh5py/shared/utils.py 90.37% <ø> (ø)
geoh5py/ui_json/utils.py 88.96% <100.00%> (+0.14%) ⬆️
geoh5py/ui_json/validation.py 85.61% <ø> (ø)
geoh5py/workspace/workspace.py 90.09% <ø> (+0.33%) ⬆️
geoh5py/ui_json/input_file.py 85.66% <68.42%> (-0.26%) ⬇️

domfournier
domfournier previously approved these changes Nov 13, 2024
Copy link
Contributor

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion. Good for test

@MatthieuCMira
Copy link
Contributor Author

I did some last changes for simplification.
Just want the approval to avoid surprises ;-)

domfournier
domfournier previously approved these changes Nov 14, 2024
Co-authored-by: domfournier <dominiquef@mirageoscience.com>
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 8346743 and detected 0 issues on this pull request.

View more on Code Climate.

@domfournier domfournier merged commit b7328d3 into develop Nov 14, 2024
12 checks passed
@domfournier domfournier deleted the GEOPY-1846b branch November 14, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants