Skip to content

Conversation

@MatthieuCMira
Copy link
Contributor

@MatthieuCMira MatthieuCMira commented Nov 8, 2024

GEOPY-1836 - return referenced values in table

- Referenced_Value_Map has now a function to map values
- ReferencedData can return the mapped values
- Options added in table and drillholes tables if mapper=True
@github-actions github-actions bot changed the title Geopy 1836 GEOPY-1836: return referenced values in table Nov 8, 2024
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 87.27273% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base (0f1e08d) to head (2f7e265).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...5py/shared/concatenation/drillholes_group_table.py 78.78% 2 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #663      +/-   ##
===========================================
+ Coverage    90.83%   90.85%   +0.02%     
===========================================
  Files          107      107              
  Lines         8965     8981      +16     
  Branches      1671     1678       +7     
===========================================
+ Hits          8143     8160      +17     
+ Misses         442      441       -1     
  Partials       380      380              
Files with missing lines Coverage Δ
geoh5py/data/data_type.py 95.25% <100.00%> (+0.04%) ⬆️
geoh5py/data/reference_value_map.py 95.65% <100.00%> (+0.41%) ⬆️
geoh5py/data/referenced_data.py 91.56% <100.00%> (+0.54%) ⬆️
geoh5py/groups/property_group_table.py 100.00% <100.00%> (+2.00%) ⬆️
geoh5py/shared/utils.py 90.37% <100.00%> (+0.06%) ⬆️
...5py/shared/concatenation/drillholes_group_table.py 87.95% <78.78%> (-0.08%) ⬇️

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 2f7e265 and detected 0 issues on this pull request.

View more on Code Climate.

@domfournier domfournier merged commit 33955d1 into develop Nov 12, 2024
12 checks passed
@domfournier domfournier deleted the GEOPY-1836 branch November 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants