Skip to content

Conversation

@saicheranb
Copy link
Contributor

@saicheranb saicheranb commented Sep 2, 2025

DEVOPS-693 - migrate from conda-lock to pixi

- Removed previous dev dependencies under [tool.poetry.group.dev.dependencies].
- Added new [tool.pixi.project] section with channels and platforms.
- Defined direct and indirect dependencies under [tool.pixi.dependencies].
- Specified PyPI options and dependencies for Pixi under [tool.pixi.pypi-options] and [tool.pixi.pypi-dependencies].
- Created environments for default and production under [tool.pixi.environments].
- Added build and test features with respective dependencies and tasks.
@github-actions github-actions bot changed the title DEVOPS-693:migrate from conda-lock to pixi DEVOPS-693: migrate from conda-lock to pixi Sep 2, 2025
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.16%. Comparing base (1241642) to head (20f5a31).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
+ Coverage    84.70%   85.16%   +0.46%     
===========================================
  Files           19       19              
  Lines         1000     1011      +11     
  Branches       132      134       +2     
===========================================
+ Hits           847      861      +14     
+ Misses         115      113       -2     
+ Partials        38       37       -1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, see some questions and suggestions

- Updated geoh5py dependency to use the latest version from PyPI instead of a specific git revision.
- Renamed section for test dependencies for clarity.
- Removed geoapps-utils dependency from editable mode.
Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, see comment about declaring dependencies

- Removed specific version constraints for numpy and scipy.
- Added pydantic as a dependency with version constraints.
- Updated conda channel from "conda-forge" to "https://repo.prefix.dev/conda-forge".
Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments about dependencies

…t.toml

- Added geoh5py dependency with version constraints.
- Updated numpy and scipy dependencies.
- Removed commented-out pip dependencies for clarity.
- Enhanced environment configurations to include dev-local and dev-git setups.
- Specified geoh5py source for dev-local and dev-git environments.
sebhmg
sebhmg previously requested changes Sep 3, 2025
Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment: do not have options (yet) for Artifactory

saicheranb and others added 11 commits September 3, 2025 15:54
Co-authored-by: Sébastien Hensgen <sebastienh@mirageoscience.com>
…rations in pyproject.toml"

This reverts commit 8a8dfdc.
- comment out the production environment for now (future versions not published yet)
- commented placeholder for a production+tests environment
- no need for the build feature (yet?)
- "default" env being a copy of "dev-git", make sure dependencies are resolved the same way
- restore the definition of "dev-local" environment
DEVOPS-693: migrate from conda-lock to pixi
as dev-local assumes ../geoh5py exists, it fails with "locked" option on CI.
Thus remove dev-local, and use a task instead for force use of local dependencies
@sebhmg sebhmg dismissed their stale review September 4, 2025 05:02

requested changes all applied

patch with task `use-local-deps` is lost upon every pixi command,
such as pixi run test
@sebhmg sebhmg requested a review from Copilot September 5, 2025 03:12

This comment was marked as outdated.

@sebhmg sebhmg dismissed their stale review September 5, 2025 03:13

addressed

To work with the published package, users would simply run conda install.
Usage of pixi here is limited to working with the local source of the package
@sebhmg sebhmg requested a review from Copilot September 10, 2025 17:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project from conda-lock to pixi for dependency management as part of DEVOPS-693. The migration involves updating the build system configuration, removing conda-lock specific files, and implementing pixi-based environment management.

Key changes:

  • Replaced conda-lock configuration with pixi project configuration in pyproject.toml
  • Updated CI/CD workflows to use pixi instead of conda package manager
  • Simplified test code by removing jinja2 template processing for recipe.yaml

Reviewed Changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/version_test.py Simplified conda recipe version parsing by removing jinja2 template processing
pyproject.toml Major restructure: moved dependencies from poetry to project section, removed conda-lock config, added comprehensive pixi configuration
.pre-commit-config.yaml Added pixi.lock to codespell exclusions
.github/workflows/python_analysis.yml Updated CI workflows to use pixi package manager instead of conda
.gitattributes Added git attributes for pixi.lock and other lock files for proper language detection

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants