Lazy #2
Open
Lazy #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
suggested changes
Dec 6, 2022
Lazy/Lazy/Lazy/MultithreadedLazy.cs
Outdated
| /// <inheritdoc/> | ||
| public override T Get() | ||
| { | ||
| ///if the value has already been calculated, there should be no locks |
There was a problem hiding this comment.
Тут обычный комментарий, не XMLDoc, так что
Suggested change
| ///if the value has already been calculated, there should be no locks | |
| // if the value has already been calculated, there should be no locks |
Lazy/Lazy/Lazy/MultithreadedLazy.cs
Outdated
| if (!Volatile.Read(ref isAlreadyCounted)) | ||
| { | ||
| value = func(); | ||
| isAlreadyCounted = true; |
There was a problem hiding this comment.
Надо ещё func занулить, чтобы сборщик мусора мог её собрать
There was a problem hiding this comment.
А isAlreadyCounted = true бесполезно, потому что строчкой ниже мы делаем то же самое, только лучше
Lazy/Lazy/Lazy/MultithreadedLazy.cs
Outdated
| } | ||
| } | ||
|
|
||
| return value!; |
There was a problem hiding this comment.
А вот плохо null-forgiving operator. Либо честно кидайте исключение, если null, либо официально разрешите значению быть null (в условии это вроде предполагалось)
Lazy/Lazy/LazyTest/LazyTest.cs
Outdated
| { | ||
| static int Increment(int number) => number + 1; | ||
| Lazy.ILazy<int> lazy = new Lazy.MultithreadedLazy<int>(() => Increment(0)); | ||
| Thread[] threads = new Thread[8]; |
Lazy/Lazy/LazyTest/LazyTest.cs
Outdated
| [Test] | ||
| public void ShouldValueNotChangeForLazyInMultithreadedMode() | ||
| { | ||
| static int Increment(int number) => number + 1; |
There was a problem hiding this comment.
Непоказательно. Из-за гонки по + 1 может получиться, что там все Lazy вызвались и посчитались, а ответ всё равно 1
Lazy/Lazy/LazyTest/LazyTest.cs
Outdated
Comment on lines
39
to
41
| threads[i] = new Thread(() => { | ||
| Assert.That(lazy.Get(), Is.EqualTo(1)); | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.