Conversation
MingboPeng
commented
Sep 14, 2025
MingboPeng
commented
- Update console path for net48 and net8 in release.yaml
- Add steps to create net8-specific plugin zip
- Update assets in .releaserc.json for net8 plugin
- Modify Makefile to build and separate net8 and net48 files
- Modify rm commands to include both lowercase and uppercase 'OpenStudio' patterns - Ensure proper cleanup of both plugin and net48 directories
…eme for net48 - Add GFuncItem class to IB_GroundHeatExchangerVertical for better G-function handling - Implement IEquatable interface for GFuncItem and PlantEquipmentOperationSchemeItem - Replace tuple with custom class in IB_PlantEquipmentOperationSchemeBase - Update related methods to use new class structures
- Update GetValidData method to use out parameter instead of tuple - Refactor GetObjsBeforeAndAfterBranch to use out parameters - Remove unnecessary tuple usage in various methods - Make minor code cleanup and formatting improvements
- Removed System.ValueTuple package reference from Ironbug.HVAC.csproj - This change simplifies the project dependencies and potentially improves build performance
- Update console path for net48 and net8 in release.yaml - Add steps to create net8-specific plugin zip - Update assets in .releaserc.json for net8 plugin - Modify Makefile to build and separate net8 and net48 files
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @MingboPeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily updates the project's build and release infrastructure to accommodate .NET 8, ensuring that both .NET 4.8 and .NET 8 specific artifacts are correctly generated and packaged. Concurrently, it undertakes a significant refactoring effort in the C# codebase to eliminate the use of ValueTuples, replacing them with more explicit out parameters or dedicated data structures for enhanced maintainability and type safety.
Highlights
- Build System Updates for .NET 8: The build and release configurations have been updated to properly support and generate artifacts for .NET 8, including separate plugin zips and console paths.
- C# Code Refactoring: ValueTuple Removal: Extensive refactoring has been performed across several C# files to replace the use of ValueTuples with explicit 'out' parameters or custom nested classes, improving code clarity and removing the System.ValueTuple dependency.
- Improved Data Encapsulation: New nested classes,
GFuncItemandPlantEquipmentOperationSchemeItem, were introduced to provide better encapsulation for related data previously handled by ValueTuples.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces support for .NET 8 builds and refactors the C# codebase to enhance compatibility by removing ValueTuple. The build script modifications in Makefile and .releaserc.json are well-aligned with creating new build artifacts for .NET 8. The C# refactoring is a significant improvement, replacing tuples with out parameters or dedicated data classes, which is beneficial for serialization and cross-framework support. I have identified a couple of areas for improvement: a syntax issue in the Makefile's rm commands and some leftover debugging code in IB_PlantLoop.cs. Addressing these points will enhance the codebase's robustness and clarity. Overall, these are positive changes for the project.
| rm ./installer/plugin-net8/openstudio* ./installer/plugin-net8/OpenStudio* -r | ||
| rm ./installer/plugin/openstudio* ./installer/plugin/OpenStudio* -r |
There was a problem hiding this comment.
The -r option for the rm command is incorrectly placed after the file paths. While some rm implementations might tolerate this, it is not standard POSIX behavior and can fail on other systems. Options should precede file arguments. It is also good practice to use the -f flag to suppress errors if the files or directories to be removed do not exist.
rm -rf ./installer/plugin-net8/openstudio* ./installer/plugin-net8/OpenStudio*
rm -rf ./installer/plugin/openstudio* ./installer/plugin/OpenStudio*
| { | ||
| //var otherJ = other?.ToJson(); | ||
| //var thisJ = this?.ToJson(); | ||
|
|
||
| return false; | ||
| //var same = this.Equals(other); | ||
| //return false; | ||
| } |
There was a problem hiding this comment.
This block contains commented-out debugging code and unreachable statements. This should be cleaned up to improve code readability and maintainability.
{
return false;
}
|
🎉 This PR is included in version 1.19.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
