Conversation
MingboPeng
commented
Sep 13, 2025
MingboPeng
commented
- Update paths for Linux build output
- Move cleanup commands for OpenStudio plugins to correct locations
- Standardize directory structure in plugin folder
- Change the path to Ironbug.Console from 'linux-x64/net8/Ironbug.Console' to 'net8/linux-x64/Ironbug.Console' - This modification ensures compatibility with the latest build structure
- Update paths for Linux build output - Move cleanup commands for OpenStudio plugins to correct locations - Standardize directory structure in plugin folder
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @MingboPeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the build and packaging process by addressing path inconsistencies and optimizing cleanup operations within the Makefile. The primary goal is to ensure that build artifacts are correctly located and unnecessary files are removed from the installer's plugin directories, leading to a more robust and predictable release process.
Highlights
- Linux Build Output Path Correction: The
build-console-linuxtarget in the Makefile has been updated to correctly reference the build output path, changing frombin/Release/linux-x64/net8tobin/Release/net8/linux-x64. - OpenStudio Plugin Cleanup Relocation: The commands responsible for removing
openstudio*files have been moved. Previously, they targeted the direct build output directories; now, they are executed on theinstaller/pluginandinstaller/plugin/net48directories after the files have been copied, ensuring cleanup applies to the installer's contents. - Standardized Directory Structure: The changes contribute to a more consistent and standardized directory structure within the
installer/pluginfolder by ensuring cleanup operations are performed on the correctly staged files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the build scripts in the Makefile. The changes correctly move the cleanup of OpenStudio plugin files to after they are copied to the installer directory, which is a good practice. The build output path for the Linux console application is also corrected. I have one suggestion to make the cleanup commands more robust.
| rm ./installer/plugin/openstudio* -r | ||
| rm ./installer/plugin/net48/openstudio* -r |
There was a problem hiding this comment.
The -r flag for rm should be placed before the file path arguments. Placing it at the end is not standard and may cause the command to fail, for example if it tries to remove a file named -r.
To make the script more robust, I also suggest adding the -f (force) flag. This will prevent the script from failing if no files match the openstudio* pattern. The -rf combination is a common idiom for this purpose.
rm -rf ./installer/plugin/openstudio*
rm -rf ./installer/plugin/net48/openstudio*
|
🎉 This PR is included in version 1.19.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
