fix(build): correct .NET Framework binary directory#146
Conversation
MingboPeng
commented
Sep 13, 2025
MingboPeng
commented
- Update Makefile to move net48 binaries correctly
- Remove unnecessary wildcard (*) in net48 directory path
- Update Makefile to move net48 binaries correctly - Remove unnecessary wildcard (*) in net48 directory path
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @MingboPeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important fix in the build configuration. It refines how .NET Framework 4.8 binaries are handled, ensuring they are placed in the correct location within the installer structure. This change prevents potential issues with the final build output and streamlines the packaging of the application.
Highlights
- Build Process Correction: The Makefile has been updated to correctly handle the movement of .NET Framework 4.8 binaries during the build process.
- Wildcard Removal: An unnecessary wildcard (*) has been removed from the mv command for the net48 directory path, ensuring the directory itself is moved rather than its contents.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to fix how .NET Framework binaries are moved in the Makefile. While the change correctly addresses the initial problem, it introduces a new issue where running the build target multiple times can lead to incorrect directory structures. I've provided a suggestion to make the build step idempotent, ensuring it behaves predictably on repeated runs.
| mkdir -p installer/plugin | ||
| mv src/Ironbug.Grasshopper/bin/x64/Release/net8-windows/* installer/plugin/ | ||
| mv src/Ironbug.Grasshopper/bin/x64/Release/net48/* installer/plugin/net48/ | ||
| mv src/Ironbug.Grasshopper/bin/x64/Release/net48 installer/plugin/ |
There was a problem hiding this comment.
While this change fixes the issue of the mv command failing when the destination directory doesn't exist, it introduces a new problem with idempotency. If this target is run more than once, mv will move the net48 directory inside the existing installer/plugin/net48 directory, resulting in a nested structure like installer/plugin/net48/net48.
To make this build step idempotent, it's better to ensure the destination directory exists and then move the contents of the source directory. This avoids the nesting issue and will simply overwrite existing files on subsequent runs, which is the desired behavior for a build script. This approach requires using the wildcard (*) to specify the contents of the directory.
mkdir -p installer/plugin/net48
mv src/Ironbug.Grasshopper/bin/x64/Release/net48/* installer/plugin/net48/
|
🎉 This PR is included in version 1.19.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
