Skip to content

fix(doc): fix ASHP output param descriptions- Thanks to @TaoZhengrong #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MingboPeng merged 1 commit into from
Jul 29, 2025
Merged

fix(doc): fix ASHP output param descriptions- Thanks to @TaoZhengrong #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Ironbug.Grasshopper/Component/Ironbug/Ironbug_HeatPumpPlantLoopEIRCooling_AirSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ protected override void RegisterInputParams(GH_Component.GH_InputParamManager pM

protected override void RegisterOutputParams(GH_Component.GH_OutputParamManager pManager)
{
pManager.AddGenericParameter("HeatPumpPlantLoopEIRCooling", "ClnHP", "Connect to hot water loop's supply side.", GH_ParamAccess.item);
pManager.AddGenericParameter("HeatPumpPlantLoopEIRCooling", "ClnHP", "Connect to chilled water loop's supply side.", GH_ParamAccess.item);
Copy link

@gemini-code-assist gemini-code-assist bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The description currently says "Connect to chilled water loop's supply side." but this component is for heating, not cooling. This should be corrected to say "Connect to hot water loop's supply side."

pManager.AddGenericParameter("HeatPumpPlantLoopEIRCooling", "ClnHP", "Connect to hot water loop's supply side.", GH_ParamAccess.item);

}


protected override void SolveInstance(IGH_DataAccess DA)
{
IB_HeatPumpPlantLoopEIRHeating hp = null;
Expand Down
6 changes: 3 additions & 3 deletions src/Ironbug.Grasshopper/Component/Ironbug/Ironbug_HeatPumpPlantLoopEIRHeating_AirSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public Ironbug_HeatPumpPlantLoopEIRHeating_Air()
}

public override GH_Exposure Exposure => GH_Exposure.quarternary;

protected override void RegisterInputParams(GH_Component.GH_InputParamManager pManager)
{
pManager.AddGenericParameter("CompanionCoolingHeatPump", "CompanionClnHP", "CompanionCoolingHeatPump", GH_ParamAccess.item);
Expand All @@ -24,10 +24,10 @@ protected override void RegisterInputParams(GH_Component.GH_InputParamManager pM

protected override void RegisterOutputParams(GH_Component.GH_OutputParamManager pManager)
{
pManager.AddGenericParameter("HeatPumpPlantLoopEIRHeating", "HtnHP", "Connect to chilled water loop's supply side.", GH_ParamAccess.item);
pManager.AddGenericParameter("HeatPumpPlantLoopEIRHeating", "HtnHP", "Connect to hot water loop's supply side.", GH_ParamAccess.item);
Copy link

@gemini-code-assist gemini-code-assist bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The description currently says "Connect to hot water loop's supply side." but this component is for cooling, not heating. This should be corrected to say "Connect to chilled water loop's supply side."

pManager.AddGenericParameter("HeatPumpPlantLoopEIRHeating", "HtnHP", "Connect to chilled water loop's supply side.", GH_ParamAccess.item);

}


protected override void SolveInstance(IGH_DataAccess DA)
{
IB_HeatPumpPlantLoopEIRCooling hp = null;
Expand Down