Skip to content

Conversation

@MinerYang
Copy link
Owner

@MinerYang MinerYang commented Mar 29, 2024

Thank you for contributing to Harbor!
https://github.com/opencontainers/distribution-spec/blob/v1.1.0/spec.md#pushing-a-blob-in-chunks

Comprehensive Summary of your change

DEBUG 
==============================================================================
~~~ REQUEST ~~~
PATCH  /v2/conformance/testrepo/blobs/uploads/1b2e9410-78ff-4973-b125-beb13a6bfae7?_state=XFq6eahlJue3bYy23SSmqdhLCICnUNcZXT-ntnxMyf17Ik5hbWUiOiJjb25mb3JtYW5jZS90ZXN0cmVwbyIsIlVVSUQiOiIxYjJlOTQxMC03OGZmLTQ5NzMtYjEyNS1iZWIxM2E2YmZhZTciLCJPZmZzZXQiOjAsIlN0YXJ0ZWRBdCI6IjIwMjQtMDMtMjhUMDc6MjY6MzEuMzcxODk4NjQyWiJ9  HTTP/1.1
HOST   : 10.202.250.166
HEADERS:
	Authorization: Bearer eyJhbGciOiJSUzI1NiIsImtpZCI6IkNBVTM6RFNTRjpGWTQ0OlJUTFY6TUQ1QzozTEZSOlRSNTc6MkJRVTpUUVZDOlNLVk06WUNHVTpNWklFIiwidHlwIjoiSldUIn0.eyJpc3MiOiJoYXJib3ItdG9rZW4taXNzdWVyIiwic3ViIjoiYWRtaW4iLCJhdWQiOiJoYXJib3ItcmVnaXN0cnkiLCJleHAiOjE3MTE2MTI1OTEsIm5iZiI6MTcxMTYxMDc5MSwiaWF0IjoxNzExNjEwNzkxLCJqdGkiOiI2QkdPbWszblMySkZvWEY3IiwiYWNjZXNzIjpbeyJ0eXBlIjoicmVwb3NpdG9yeSIsIm5hbWUiOiJjb25mb3JtYW5jZS90ZXN0cmVwbyIsImFjdGlvbnMiOlsicHVsbCIsInB1c2giLCJkZWxldGUiXX1dfQ.DpDSXN0_d5YdBfi3QRUUagJStyhOFrGh534i8DfrGzoBwt2uTBu6NTYDdzCffApiTOcGTiciRyEtdm8b1kbV9Ezf_qxom7WskYWWj9-29q_jZ7kM5_1rSsec2rS272vo3JQe7xfluGblwyfSZD3w3Qgpdw71uX0cz9FylcqiyC00LNU5jQPmsaHTEAe0SlIA1S0UDpzAOicB3EOAToWPD7YEl6OyYxwnppwMc0J0das4h43NNiXEYAoCWOWxbvroJHW7QXXVmjmiOjbxDvdQNLD3pnWnnkv9_CIoOi78jbimuIafN15ZN0lHNT_vWDyXI7JHK2n7Lmxctte8sRazjW1fZRNKaHKREs2GjgP2qkiBIoW22S1YqTBJPy_BduJ5ylhrX98SzxMDtbAMSm0-KIlTG-jsCgEXzDL_Tr2yPSsGtl5YU4eJg6MznhBOmT1jyFYUTP0sKUN9gvTibJ3KYFJIWRFEpiBDYkpVKJWtHIx76RWu6yLJHSMEXU0xXC1e7miByVOP75364N2ujHFcEcEwOCMER9EfJpjsFyPkidpkj0K2gV8o-pvFw97u8WJD8LVT7qk2B2iAAbXYAlGtSLRPVHWMs1gy9GPB_BDiFn8QWUyNWcGuRaJ9maP0OUn3coJoeEwnOQbGaDuJfVUfJZpUPlRkhjE4fqaDVHB3njo
	Content-Length: 20
	Content-Range: 22-41
	Content-Type: application/octet-stream
	User-Agent: distribution-spec-conformance-tests
BODY   :
***** BODY IS byte(s) (size - 20) *****
------------------------------------------------------------------------------
~~~ RESPONSE ~~~
STATUS       : 202 Accepted
PROTO        : HTTP/1.1
RECEIVED AT  : 2024-03-28T07:26:31.403369283Z
TIME DURATION: 7.695377ms
HEADERS      :
	Connection: keep-alive
	Content-Length: 0
	Date: Thu, 28 Mar 2024 07:26:31 GMT
	Docker-Distribution-Api-Version: registry/2.0
	Docker-Upload-Uuid: 1b2e9410-78ff-4973-b125-beb13a6bfae7
	Location: https://10.202.250.166/v2/conformance/testrepo/blobs/uploads/1b2e9410-78ff-4973-b125-beb13a6bfae7?_state=AeIpeJY-t3htPf1xcOVG3LJBv2ga1rjvb5GaT9Yydqx7Ik5hbWUiOiJjb25mb3JtYW5jZS90ZXN0cmVwbyIsIlVVSUQiOiIxYjJlOTQxMC03OGZmLTQ5NzMtYjEyNS1iZWIxM2E2YmZhZTciLCJPZmZzZXQiOjIwLCJTdGFydGVkQXQiOiIyMDI0LTAzLTI4VDA3OjI2OjMxWiJ9
	Range: 0-19
	Server: nginx
	Set-Cookie: sid=dbc7d76d465616bd38c35c97f7e4c57d; Path=/; HttpOnly
	X-Request-Id: d38860d5-6d73-4fd6-b33c-30e3dd5683a0
BODY         :

==============================================================================

Signed-off-by: yminer <yminer@vmware.com>
@MinerYang
Copy link
Owner Author

MinerYang commented Mar 29, 2024

After apply this checking at middleware, we will get disorder blob chunk uploads error as below

2024/03/29 07:08:59.625490 DEBUG RESTY 
==============================================================================
~~~ REQUEST ~~~
PATCH  /v2/test/mock/blobs/uploads/67f89fc6-ae20-4c3c-93fd-60f67398320e?_state=NwfYuVzfNF6l4kgx7GtwxNm2Ze1ayGbSCWFUvZGUZAN7Ik5hbWUiOiJ0ZXN0L21vY2siLCJVVUlEIjoiNjdmODlmYzYtYWUyMC00YzNjLTkzZmQtNjBmNjczOTgzMjBlIiwiT2Zmc2V0IjowLCJTdGFydGVkQXQiOiIyMDI0LTAzLTI5VDA3OjA4OjU5LjU4OTM2OTA0M1oifQ%3D%3D  HTTP/1.1
HOST   : 10.202.250.166
HEADERS:
        Authorization: Bearer eyJhbGciOiJSUzI1NiIsImtpZCI6IktCN0k6UU5QVDo3RlA3OkYyM0M6M0NDNDpDNkdaOlVJSlM6WkJaSDpUTlM3OlRJWlE6QVBKNzpaUFRRIiwidHlwIjoiSldUIn0.eyJpc3MiOiJoYXJib3ItdG9rZW4taXNzdWVyIiwic3ViIjoiYWRtaW4iLCJhdWQiOiJoYXJib3ItcmVnaXN0cnkiLCJleHAiOjE3MTE2OTc5MzksIm5iZiI6MTcxMTY5NjEzOSwiaWF0IjoxNzExNjk2MTM5LCJqdGkiOiJGZmR6U1VmV2JtaDNWaGFUIiwiYWNjZXNzIjpbeyJ0eXBlIjoicmVwb3NpdG9yeSIsIm5hbWUiOiJ0ZXN0L21vY2siLCJhY3Rpb25zIjpbInB1bGwiLCJwdXNoIiwiZGVsZXRlIl19XX0.j3XAf1bPd111qnnY8K9SpmXubXmD3Tuan5tIiksHNM9L-ysF4HjpwFVcvUj7KdflR9MudK1hGAg213IiscVlT6M7PnbFk2j6FVYYZSjiXQX5SJiVa4EKy9upSZqwIxRIQqR9y_MiNGzY30G5FBRnD5GNzTPfal3X3q7dwseafm7wSvh9uQhXbaeU7XkpgC2vvADzYXz8L2OmGOUkkj9XicW364GKe9r0V-AZKav3jiFs3-WwjYC-RgkLtzLtfPEFyrrEwDUkhrbSR8J-0V8_KLcT_fYWYJiHjHNvVubBYv5TbDY3JNNTztN80VgaclX9FKkbTxqPRx_d0V8pDYolwr3Hm6LBIwODXvF5Occ6VBHScmqGgHnAGXINW8rhJ11JAl5ph95J1ryYCTDsLo1Ud9kHIbBWmm3iZ6sEhLPg4h6oGHrg4N8LKrtireCXr91lzROAu-HI4jRguFNTH6bJsYTanj-O6EEbu6fqfSF_GwrmcK5-X9kqJz6IFaeh6WiNKyoazKk3FHjSnAmV89VdDTl4pxXqVVC4ApyDSFFXuhesv9dLDS3BkXup2ZQica4ggk_wyrdSCU0OYf2AuXEVbqlMsFUJCY0kMubXSi4NNXeecM-usAefSFrF3MfQBWYordG3l2Gc1WMMMESd0c6G1SPQGsQ2bIuYyHEwpQ8ELAg
        Content-Length: 16
        Content-Range: 17-32
        Content-Type: application/octet-stream
        User-Agent: harbor-tests
BODY   :
***** BODY IS byte(s) (size - 17) *****
------------------------------------------------------------------------------
~~~ RESPONSE ~~~
STATUS       : 416 Not Found
PROTO        : HTTP/1.1
RECEIVED AT  : 2024-03-29T07:08:59.625427142Z
TIME DURATION: 9.054216ms
HEADERS      :
        Connection: keep-alive
        Content-Length: 74
        Content-Type: application/json; charset=utf-8
        Date: Fri, 29 Mar 2024 07:08:59 GMT
        Server: nginx
        Set-Cookie: sid=4873f25c7c0fa890bc7e1c2912c4c2b1; Path=/; HttpOnly
        X-Request-Id: d83fc7a9-8df8-49da-9d98-b0ec7558206d
BODY         :
{
   "errors": [
      {
         "code": "RequestRange_Unsatisfy",
         "message": "Request Range is disordered"
      }
   ]
}

wy65701436 added a commit that referenced this pull request Jan 22, 2026
* Create harbor-backup

Signed-off-by: teletechie <cecilie.monsen@telenor.no>

* Create harbor-restore

Signed-off-by: teletechie <cecilie.monsen@telenor.no>

* Create README.md

Signed-off-by: teletechie <cecilie.monsen@telenor.no>

* Update README.md

Signed-off-by: teletechie <cecilie.monsen@telenor.no>

* pr review comment #2

remove opening parenthesis in message. this matches the other messages

Signed-off-by: teletechie <cecilie.monsen@telenor.no>

* pr review comment #1

Fix the three docker calls so they enforce returning of status.
remove unused if block that could never be triggered.

Signed-off-by: teletechie <cecilie.monsen@telenor.no>

* Issue warning when becking up chartmuseum data

chartmuseum is deprecated.
This change issues a warning when the backup detect chartmuseum data, but still backs it up. there is no message about not finding chartmuseum data if they don't exist.

Signed-off-by: teletechie <cecilie.monsen@telenor.no>

* issue warning when restoring chartmuseum data

chartmuseum is deprecated.
this update issues a warning when detecting chartmuseum data in the restore, but will still restore the files. no message is given when chartmuseum data are not found.

Signed-off-by: teletechie <cecilie.monsen@telenor.no>

---------

Signed-off-by: teletechie <cecilie.monsen@telenor.no>
Co-authored-by: Wang Yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants