sodium 2.4.0 and sodiummac 3.4.0 #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without cpu string changes for now, we'll see about that
Knawk
reviewed
Jan 1, 2025
Member
Knawk
left a comment
Knawk
left a comment
There was a problem hiding this comment.
The source diffs look good to me, but I'm hesitant to legalize these changes until we have some written guidance on how (and whether) players should pick values for the newly added settings. Does that already exist, by any chance?
Knawk
approved these changes
Jan 10, 2025
Member
Knawk
left a comment
Knawk
left a comment
There was a problem hiding this comment.
(from Discord discussion) DesktopFolder made an explanation/guidance video (to be made public in the future), so this looks good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without cpu string changes for now, we'll see about that
sources:
Minecraft-Java-Edition-Speedrunning/sodium@b8785cd...1.16.1
Minecraft-Java-Edition-Speedrunning/sodium@94de2ac...mac/1.16.1