-
Notifications
You must be signed in to change notification settings - Fork 25
chore: Prepare for release 6.0.0 #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares release 6.0.0 by bumping the version number, removing Python 2 support, and cleaning up documentation.
- Removed Python 2 references and legacy conditional logic in setup.py.
- Updated version information in python3/raygun4py/version.py to 6.0.0.
- Updated documentation in README.rst and CHANGELOG.md to reflect the new release and breaking changes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Removed Python 2 conditional logic; updated description and classifiers. |
| python3/raygun4py/version.py | Bumped version number from 5.0.0 to 6.0.0. |
| README.rst | Cleaned documentation to remove Python 2 references and added new code examples. |
| CHANGELOG.md | Added release notes and detailed changes for version 6.0.0. |
|
|
||
| Pass a callback function to this method to configure custom grouping logic. The callback should take one parameter, an instance of RaygunMessage, and return a string between 1 and 100 characters in length (see 'Custom Grouping Logic' below for more details). | ||
|
|
||
| .. code:: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does the .. mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the formatting of rst files to introduce codeblocks.
| base_dir = "python2" | ||
| if sys.version_info[0] == 3: | ||
| base_dir = "python3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still support python 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do mention it here - https://raygun.com/documentation/language-guides/python/crash-reporting/installation/
Therefore, I'm not sure if we want to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support it in the project anymore, the code was deleted back in version 5, so having this setup step would be incorrect.
Users can still use version 4.4.0 if they want to use python2
sumitramanga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor considerations but looks good!
Description 📝
Purpose:
Prepare release of 6.0.0
Approach:
Bump major version since this release includes a breaking change.
Also, this PR includes a small documentation cleanup and removing references to python2, which support was dropped in version 5.
Type of change
fix:Bug fix (non-breaking change which fixes an issue)feat:New feature (non-breaking change which adds functionality)chore:Chore task, release or small impact changeci:CI configuration changeUpdates
Related issues
Test plan 🧪
Author to check 👓
Reviewer to check ✔️