openbox/stacking: optimize stacking list operations to O(1) #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
stacking_nodepointer to theObWindowstruct, caching the window's position in the globalstacking_list.Previously, operations like
stacking_remove,stacking_raise, and occlusion checks required callingg_list_findor iterating through the list, resulting in O(N) complexity. For setups with many windows, this created unnecessary CPU overhead during focus changes and restacking.By utilizing the cached
GListnode:stacking_detach_node.