About page

[ehne]

{
   "Added":[
      "about.html template",
      "about() function to main.py",
      "changelog.json and guide to creating an update",
      "border styling to the .details class",
      ".details-content class to add padding to the details content."
   ],
   "Changed":[
      "footer links now link to the about page, as opposed to the collective fullstack website and the contributions graph.",
      "font weight of <b></b> tags is now 700"
   ]
}

it all seems to work, I'm mainly making a pr for this so we have to use the changelog sooner.

closes #51

[Midataur]

I had a weird style bug here (yes I did hard reload). Also maybe we could put some more links in the top nav bar? I struggled to find the about page and I was actively looking for it. But yeah, looks good, just maybe need some more stuff in the change log and add a tip jar? Drop downs could probably be just static since it's an about page and they are meant to have a lot of info visible, but that may just be me.

[ehne]

huh, that's a weird bug. it looks fine on my end. maybe its how Firefox handles list items?

I think it's probably fine to leave the about link in the footer, as I don't want the nav bar to be too crowded, like, I want to keep that bit fairly minimalist.

but also, yeah, we should add all the other stuff that we'd done into the changelog, its just that that will take a while to do.

[Midataur]

I mean it's just that I don't think anyone will ever see it there, and if that's our funding link

…

On Thu, 10 Sep 2020, 11:30 darcy, ***@***.***> wrote: [image: Screen Shot 2020-09-10 at 11 24 54 am] <https://user-images.githubusercontent.com/7551957/92670855-42b43780-f358-11ea-823c-7e94a5434940.png> huh, that's a weird bug. it looks fine on my end. maybe its how Firefox handles list items? I think it's probably fine to leave the about link in the footer, as I don't want the nav bar to be too crowded, like, I want to keep that bit fairly minimalist. but also, yeah, we should add all the other stuff that we'd done into the changelog, its just that that will take a while to do. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEN7JDJXTL7MENMDXSK7VJ3SFAT3DANCNFSM4RDXVKKA> .

[ehne]

hmm, I guess, I just don't want to put anything else in the nav bar, although, I guess I could but a button in there on the main page? (index.html) but not any page that has a room code, would that work?

[Midataur]

I mean imo it would look fine. Maybe try both methods?

…

On Thu, 10 Sep 2020, 11:35 darcy, ***@***.***> wrote: hmm, I guess, I just don't want to put anything else in the nav bar, although, I guess I could but a button in there on the main page? (index.html) but not any page that has a room code, would that work? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEN7JDL76ZOJL2ZMOPQATLTSFAUPZANCNFSM4RDXVKKA> .

[ehne]

yeah, ill give both of 'em a shot at lunch.
also, ill try figure out why the list items are being weird.

[ehne]

okay, so I tried it with either hiding on room code views, or just on every page.

here is what it looks like if I only show it on rooms that don't have room codes:

and here is what it looks like when its just always shown:

[jmang00]

Yeah I agree with Darcy on this one, I think that's a good solution though.

[Midataur]

Fix that bug with the list and we still gotta find a good place to put the link

[ehne]

well, jai and I have agreed that the nav bar with no room code is the best place to put it.
and I'm currently working on the list problem.

[ehne]

I have fixed the list positioning problem, here it is in Firefox:

and safari:

[Midataur]

Radical

…

On Fri, 11 Sep 2020, 11:42 darcy, ***@***.***> wrote: I have fixed the list positioning problem, here it is in Firefox: [image: Screen Shot 2020-09-11 at 11 40 30 am] <https://user-images.githubusercontent.com/7551957/92839689-9c356880-f423-11ea-8533-6842c15031a4.png> and safari: [image: Screen Shot 2020-09-11 at 11 41 11 am] <https://user-images.githubusercontent.com/7551957/92839787-b2432900-f423-11ea-9039-36ac5b8fbed6.png> — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEN7JDNGOZBDGPVE4QAYJVDSFF57FANCNFSM4RDXVKKA> .

[Midataur]

Can we add the tip jar?

…

On Fri, 11 Sep 2020, 11:56 Max Petschack, ***@***.***> wrote: Radical On Fri, 11 Sep 2020, 11:42 darcy, ***@***.***> wrote: > I have fixed the list positioning problem, here it is in Firefox: > [image: Screen Shot 2020-09-11 at 11 40 30 am] > <https://user-images.githubusercontent.com/7551957/92839689-9c356880-f423-11ea-8533-6842c15031a4.png> > > and safari: > [image: Screen Shot 2020-09-11 at 11 41 11 am] > <https://user-images.githubusercontent.com/7551957/92839787-b2432900-f423-11ea-9039-36ac5b8fbed6.png> > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <#53 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEN7JDNGOZBDGPVE4QAYJVDSFF57FANCNFSM4RDXVKKA> > . >

[ehne]

have we set up liberapay?

[Midataur]

I personally have

…

On Fri, 11 Sep 2020, 11:57 darcy, ***@***.***> wrote: have we set up liberapay? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEN7JDLAOIW7P3CSECMYB2TSFF72JANCNFSM4RDXVKKA> .

[ehne]

have you set up a MathSender team? if not ill make one now

[Midataur]

Yeah go ahead

…

On Fri, 11 Sep 2020, 12:00 darcy, ***@***.***> wrote: have you set up a MathSender team? if not ill make one now — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEN7JDIE7EFQHX7MZJKUVQ3SFGADNANCNFSM4RDXVKKA> .

[ehne]

does this look good? (Icon will be changed in the icons branch)

and we can add jai to the liberapay team

[Midataur]

Is it possible to make it look less like an error message?

[ehne]

yeah, I guess, I can just get rid of the icon for the time being?

[Midataur]

Yeah, maybe add a dollar sign or something like that? Idk

…

On Fri, 11 Sep 2020, 13:14 darcy, ***@***.***> wrote: yeah, I guess, I can just get rid of the icon for the time being? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEN7JDOB36V4ZB3HVVFJZBTSFGI2DANCNFSM4RDXVKKA> .

[ehne]

yeah, for the time being i'll just use a dollar sign.

in future, I've found a couple of different icons I like:

(no, there isn't just like, a dollar sign inside a circle icon, smh)

which ones do you like?

[jmang00]

All the icons are pretty good, I like the person-heart and bank ones most

[ehne]

yeah, I was going to go with the person heart one, its the most "friendly" one out of the options, y'know?